You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by do...@apache.org on 2023/10/17 23:11:26 UTC

[spark] branch branch-3.4 updated: [MINOR][SQL] Remove signature from Hive thriftserver exception

This is an automated email from the ASF dual-hosted git repository.

dongjoon pushed a commit to branch branch-3.4
in repository https://gitbox.apache.org/repos/asf/spark.git


The following commit(s) were added to refs/heads/branch-3.4 by this push:
     new e2911e7c208 [MINOR][SQL] Remove signature from Hive thriftserver exception
e2911e7c208 is described below

commit e2911e7c208f49f4fb7575bdd33c92e0a3b645a2
Author: Sean Owen <sr...@gmail.com>
AuthorDate: Tue Oct 17 16:10:56 2023 -0700

    [MINOR][SQL] Remove signature from Hive thriftserver exception
    
    ### What changes were proposed in this pull request?
    
    Don't return expected signature to caller in Hive thriftserver exception
    
    ### Why are the changes needed?
    
    Please see private discussion
    
    ### Does this PR introduce _any_ user-facing change?
    
    No
    
    ### How was this patch tested?
    
    Existing tests
    
    ### Was this patch authored or co-authored using generative AI tooling?
    
    No
    
    Closes #43402 from srowen/HiveCookieSigner.
    
    Authored-by: Sean Owen <sr...@gmail.com>
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
    (cherry picked from commit cf59b1f51c16301f689b4e0f17ba4dbd140e1b19)
    Signed-off-by: Dongjoon Hyun <dh...@apple.com>
---
 .../src/main/java/org/apache/hive/service/CookieSigner.java            | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
index 782e47a6cd9..4b8d2cb1536 100644
--- a/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
+++ b/sql/hive-thriftserver/src/main/java/org/apache/hive/service/CookieSigner.java
@@ -81,8 +81,7 @@ public class CookieSigner {
       LOG.debug("Signature generated for " + rawValue + " inside verify is " + currentSignature);
     }
     if (!MessageDigest.isEqual(originalSignature.getBytes(), currentSignature.getBytes())) {
-      throw new IllegalArgumentException("Invalid sign, original = " + originalSignature +
-        " current = " + currentSignature);
+      throw new IllegalArgumentException("Invalid sign");
     }
     return rawValue;
   }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org