You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ksobrenat32 (via GitHub)" <gi...@apache.org> on 2025/07/25 22:54:10 UTC
[PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
ksobrenat32 opened a new pull request, #35701:
URL: https://github.com/apache/beam/pull/35701
The idea is to setup the users and permissions for the GCP project using Terraform, allowing for easier management and automation of the infrastructure. This commit includes the following files:
- `infra/.terraform.lock.hcl`: Lock file for Terraform dependencies.
- `infra/README.md`: Documentation for the Terraform setup.
- `infra/config.auto.tfvars`: Configuration variables for the Terraform project.
- `infra/generate.py`: Python script to generate user configurations based on current users. This should be ran before migration to ensure having the latest roles version.
- `infra/main.tf`: Main Terraform configuration file for the GCP project.
- `infra/requirements.txt`: Python dependencies for the `generate.py` script.
- `infra/users.tf`: Terraform configuration for managing GCP users.
> Related as part 1 of the PR # #35107
> Next steps are:
> - Create the gcp bucket to store terraform state and initialize it.
> - Add GA workflow to run when `users.yml` suffers changes to update the gcp roles
> - implement custom roles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3120684824
Assigning reviewers:
R: @shunping added as fallback since no labels match configuration
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3133724637
thanks @damccorm - LGTM pending Danny's comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3138012579
we are working to initialize iam management with terraform
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem merged PR #35701:
URL: https://github.com/apache/beam/pull/35701
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "ksobrenat32 (via GitHub)" <gi...@apache.org>.
ksobrenat32 commented on code in PR #35701:
URL: https://github.com/apache/beam/pull/35701#discussion_r2241170425
##########
infra/README.md:
##########
@@ -0,0 +1,98 @@
+<!--
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3124848741
I don't have context of this. @damccorm do you please find a reviewer for this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "pabloem (via GitHub)" <gi...@apache.org>.
pabloem commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3138038755
okay we have migrated this and permissions are now managed via terraform. @ksobrenat32 will send an email to dev@ explaining the changes. I will merge once he pushes the last changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "ksobrenat32 (via GitHub)" <gi...@apache.org>.
ksobrenat32 commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3120627127
This is being tested on a personal GCP project with the ID testing-me-460223, feel free to review the permissions over [here](https://console.cloud.google.com/iam-admin/iam?hl=en&inv=1&invt=Ab3vAA&project=testing-me-460223)
I have added the following emails as project owners:
- dannymccormick@google.com (@damccorm)
- yathu@google.com
- pabloem@google.com (@pabloem)
- polecito.em@gmail.com
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #35701:
URL: https://github.com/apache/beam/pull/35701#issuecomment-3120608671
> [!IMPORTANT]
> **Installation incomplete:** to start using Gemini Code Assist, please ask the [organization owner(s)](https://docs.github.com/en/organizations/managing-peoples-access-to-your-organization-with-roles/roles-in-an-organization#organization-owners) to visit the [Gemini Code Assist Admin Console](https://codeassist.google/code-review/login) and sign the Terms of Services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add Terraform configuration and IAM management scripts for GCP project [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #35701:
URL: https://github.com/apache/beam/pull/35701#discussion_r2240712180
##########
infra/README.md:
##########
@@ -0,0 +1,98 @@
+<!--
Review Comment:
Minor: Could we please move these files into a dedicated directory (maybe `infra/Iam`?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org