You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "dsmiley (via GitHub)" <gi...@apache.org> on 2026/09/03 15:05:52 UTC

[PR] HttpSolrClient withTheseParamNamesInTheUrl defaults [solr]

dsmiley opened a new pull request, #4871:
URL: https://github.com/apache/solr/pull/4871

   HttpSolrClient.withTheseParamNamesInTheUrl now has a default set (if you don't call it) that ensures many interesting parameters for routing or fundamental purpose end up in the URL.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] HttpSolrClient withTheseParamNamesInTheUrl defaults [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley commented on PR #4871:
URL: https://github.com/apache/solr/pull/4871#issuecomment-5533622884

   Gonna merge Sunday if no feedback.
   
   One possible consideration is, should these defaults be augmented/merged with a call to explicitly set them.  I don't think I care much either way... but a benefit to not doing that is that a user can explicitly insist no params go in the URL if they want.  Granted I don't know why they would care.  Only one place in Solr, Distributed URP, is this called, which is to set the update distribution params.  Update requests don't use any of these default params, so whatever.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org


Re: [PR] HttpSolrClient withTheseParamNamesInTheUrl defaults [solr]

Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley merged PR #4871:
URL: https://github.com/apache/solr/pull/4871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org