You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Aljoscha Krettek (JIRA)" <ji...@apache.org> on 2019/07/08 14:02:00 UTC
[jira] [Commented] (FLINK-13123) Align Stop/Cancel Commands in CLI
and REST Interface and Improve Documentation
[ https://issues.apache.org/jira/browse/FLINK-13123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880381#comment-16880381 ]
Aljoscha Krettek commented on FLINK-13123:
------------------------------------------
I agree. 👌
But what's the reason for renaming {{-s}} to {{-p}} for the savepoint location?
> Align Stop/Cancel Commands in CLI and REST Interface and Improve Documentation
> ------------------------------------------------------------------------------
>
> Key: FLINK-13123
> URL: https://issues.apache.org/jira/browse/FLINK-13123
> Project: Flink
> Issue Type: Improvement
> Affects Versions: 1.9.0
> Reporter: Konstantin Knauf
> Assignee: Konstantin Knauf
> Priority: Major
>
> Currently, the REST API and CLI around stopping and cancelling jobs are not aligned in terms of terminology and the differences between {{cancel}} and {{job}} are not as clear as they could be.
> I would like to make the following changes to the CLI:
> * add deprecation warning for {{cancel -s}} command and redirect users to {{stop}}
> * rename {{-s}} of {{stop}} command to {{-p}} for savepoint location. Emphasize that this is optional, as a savepoint is taken in any case
> I would like to make the following changes to the REST API:
> * Rename {{stop-with-savepoint}} to {{stop}}
> * Log a Deprecation warning with /savepoints is used in conjuction with cancel.
> * Rename "endOfEventTime" to "drain" in accordance with the CLI
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)