You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/06/23 14:43:12 UTC

[Issue 125143] New: helpex Export::CopyFile is too slow

https://issues.apache.org/ooo/show_bug.cgi?id=125143

          Issue ID: 125143
        Issue Type: DEFECT
           Summary: helpex Export::CopyFile is too slow
           Product: Internationalization
           Version: OOo 3.3 or older
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: P3
         Component: helpcontent
          Assignee: issues@openoffice.apache.org
          Reporter: hdu@apache.org

Building the helpcontent2 module takes many minutes, especially when WITH_LANG
is active. Tracing the build progress shows that the seemingly simple function
CopyFile() takes a significant amount of time. Looking at the relevant code
there is some copying of single lines going on, which could be replaced by
something much faster.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

--- Comment #3 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1605044 into trunk:
#i125143# reduce helpex stack usage to prevent intermittent failures

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED
           Assignee|issues@openoffice.apache.or |hdu@apache.org
                   |g                           |
   Target Milestone|---                         |4.2.0

--- Comment #2 from hdu@apache.org <hd...@apache.org> ---
Fixed with the commit above. It has been measured to reduce the time per
language by about 30%.

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

--- Comment #1 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1604786 into trunk:
#i125143# use bulk-copying instead of line-wise in helpex Export::CopyFile()

-- 
You are receiving this mail because:
You are the assignee for the issue.
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jsc@apache.org
              Flags|4.1.1_release_blocker?      |4.1.1_release_blocker+

--- Comment #5 from jsc@apache.org ---
grant showstopper flag

not directly related for the release but a huge improvement to speed up the
release preparation

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|4.2.0                       |4.1.1

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

--- Comment #6 from SVN Robot <sv...@dev.null.org> ---
"hdu" committed SVN revision 1608366 into branches/AOO410:
#i125143# speedup helpex by using bulk-copy instead of doing it line-wise

-- 
You are receiving this mail because:
You are watching all issue changes.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

hdu@apache.org <hd...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Latest|---                         |4.2.0-dev
    Confirmation on|                            |
              Flags|                            |4.1.1_release_blocker?

--- Comment #4 from hdu@apache.org <hd...@apache.org> ---
With so many languages in our releases and even more for AOO 4.1.1 such
speedups for each language may help in the release process, so we should
consider to merge the fix into the release branch.

-- 
You are receiving this mail because:
You are watching all issue changes.

4.1.1_release_blocker requested: [Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
hdu@apache.org <hd...@apache.org> has asked  for 4.1.1_release_blocker:
Issue 125143: helpex Export::CopyFile is too slow
https://issues.apache.org/ooo/show_bug.cgi?id=125143


------- Additional Comments from hdu@apache.org <hd...@apache.org>
With so many languages in our releases and even more for AOO 4.1.1 such
speedups for each language may help in the release process, so we should
consider to merge the fix into the release branch.

[Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=125143

jsc@apache.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |VERIFIED

-- 
You are receiving this mail because:
You are watching all issue changes.

4.1.1_release_blocker granted: [Issue 125143] helpex Export::CopyFile is too slow

Posted by bu...@apache.org.
jsc@apache.org has granted hdu@apache.org <hd...@apache.org>'s request for
4.1.1_release_blocker:
Issue 125143: helpex Export::CopyFile is too slow
https://issues.apache.org/ooo/show_bug.cgi?id=125143


------- Additional Comments from jsc@apache.org
grant showstopper flag

not directly related for the release but a huge improvement to speed up the
release preparation