You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/07/06 01:48:26 UTC

[GitHub] [incubator-druid] vogievetsky opened a new pull request #8033: Web console: fix query input undo

vogievetsky opened a new pull request #8033: Web console: fix query input undo
URL: https://github.com/apache/incubator-druid/pull/8033
 
 
   Fixed the issue where switching from the hjson mode to sql mode in the query view input field would destroy the undo buffer. This is done by removing the `key` attribute in the query input which caused the component to remount. The key attribute was originally there because there would be some error thrown from the `AceEditor` when switching from `hjson` to `sql` mode due to one having folding and the other not.
   
   While we are at it made the `sql` highlighter better for DruidSQL

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org