You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "sunank200 (via GitHub)" <gi...@apache.org> on 2025/11/13 08:34:15 UTC
[PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
sunank200 opened a new pull request, #58253:
URL: https://github.com/apache/airflow/pull/58253
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
The test `test_example_dag_hashes_are_always_consistent` was failing in Postgres 17 CI while passing in Postgres 13 in [https://github.com/apache/airflow/actions/runs/19315183483](https://github.com/apache/airflow/actions/runs/19315183483). The issue was that DAG hashes were non-deterministic due to task serialization order depending on dictionary iteration order, which could vary between environments or database versions.
## Fix
- Sort tasks by `task_id` during serialization in `serialize_dag()` to ensure deterministic ordering regardless of dictionary iteration order
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
<!-- Please keep an empty line above the dashes. -->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 commented on PR #58253:
URL: https://github.com/apache/airflow/pull/58253#issuecomment-3527653205
Closing this for now as this is not the right root cause and it passed in current run. I have created the PR to log (dag_id, hash) in the test https://github.com/apache/airflow/pull/58264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #58253:
URL: https://github.com/apache/airflow/pull/58253#discussion_r2522460269
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -366,6 +366,11 @@ def _sort_serialized_dag_dict(cls, serialized_dag: Any):
[cls._sort_serialized_dag_dict(i) for i in serialized_dag],
key=lambda x: x["__var"]["task_id"],
)
+ if all("task_id" in i for i in serialized_dag):
+ return sorted(
+ [cls._sort_serialized_dag_dict(i) for i in serialized_dag],
Review Comment:
```suggestion
(cls._sort_serialized_dag_dict(i) for i in serialized_dag),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on PR #58253:
URL: https://github.com/apache/airflow/pull/58253#issuecomment-3527026482
> Sort tasks by task_id during serialization in serialize_dag() to ensure deterministic ordering regardless of dictionary iteration order
On the surface of it, this seems wrong. From Python3.7+ the dict iteration order is the insertion order in the dictionary, and we _want_ to maintain that insertion don't we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "sunank200 (via GitHub)" <gi...@apache.org>.
sunank200 closed pull request #58253: Fix DAG hash calculation to be deterministic across database versions to fix CI
URL: https://github.com/apache/airflow/pull/58253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #58253:
URL: https://github.com/apache/airflow/pull/58253#discussion_r2522625512
##########
airflow-core/src/airflow/models/serialized_dag.py:
##########
@@ -366,6 +366,11 @@ def _sort_serialized_dag_dict(cls, serialized_dag: Any):
[cls._sort_serialized_dag_dict(i) for i in serialized_dag],
key=lambda x: x["__var"]["task_id"],
)
+ if all("task_id" in i for i in serialized_dag):
+ return sorted(
+ [cls._sort_serialized_dag_dict(i) for i in serialized_dag],
Review Comment:
Or actually remove those parentheses at all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #58253:
URL: https://github.com/apache/airflow/pull/58253#issuecomment-3526583358
I guess redis change is unrelated /flaky as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb commented on code in PR #58253:
URL: https://github.com/apache/airflow/pull/58253#discussion_r2522806498
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2486,7 +2486,9 @@ def serialize_dag(cls, dag: DAG) -> dict:
try:
serialized_dag = cls.serialize_to_json(dag, cls._decorated_fields)
serialized_dag["_processor_dags_folder"] = DAGS_FOLDER
- serialized_dag["tasks"] = [cls.serialize(task) for _, task in dag.task_dict.items()]
+ serialized_dag["tasks"] = [
+ cls.serialize(task) for _, task in sorted(dag.task_dict.items(), key=lambda x: x[0])
+ ]
Review Comment:
Yeah, this is not good. It will mean that the order of tasks in the UI is always alphabetical (once dependencies are taken in to account), and it should not be -- it should be tasks added first to the dag appear higher up in the grid view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix DAG hash calculation to be deterministic across database versions to fix CI [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #58253:
URL: https://github.com/apache/airflow/pull/58253#discussion_r2522946126
##########
airflow-core/src/airflow/serialization/serialized_objects.py:
##########
@@ -2486,7 +2486,9 @@ def serialize_dag(cls, dag: DAG) -> dict:
try:
serialized_dag = cls.serialize_to_json(dag, cls._decorated_fields)
serialized_dag["_processor_dags_folder"] = DAGS_FOLDER
- serialized_dag["tasks"] = [cls.serialize(task) for _, task in dag.task_dict.items()]
+ serialized_dag["tasks"] = [
+ cls.serialize(task) for _, task in sorted(dag.task_dict.items(), key=lambda x: x[0])
+ ]
Review Comment:
🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org