Re: [GitHub] [logging-log4j2] ichux commented on a change in pull request #607: LOG4J2-3198: Log4j2 no longer formats lookups in messages by default

[Remko Popma <re...@gmail.com>]

Yes. It certainly looks like it (on my phone now).

On Thu, Dec 16, 2021 at 14:53 GitBox <gi...@apache.org> wrote:

>
> ichux commented on a change in pull request #607:
> URL:
> https://github.com/apache/logging-log4j2/pull/607#discussion_r770242666
>
>
>
> ##########
> File path: src/site/xdoc/manual/layouts.xml.vm
> ##########
> @@ -1455,9 +1455,9 @@ WARN  [main]: Message 2</pre>
>              <tr>
>                <td align="center">
>                  <a name="PatternMessage"/>
> -                <b>m</b>{nolookups}{ansi}<br />
> -                <b>msg</b>{nolookups}{ansi}<br />
> -                <b>message</b>{nolookups}{ansi}
> +                <b>m</b>{ookups}{ansi}<br />
>
> Review comment:
>        Isn't this a *typo*? As in *ookups* in place of *lookups*?
>
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org
>
>
>