You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by ch...@apache.org on 2026/08/13 06:39:51 UTC
(shardingsphere) branch master updated: Parse PostgreSQL altered column nullability (#39432)
This is an automated email from the ASF dual-hosted git repository.
FlyingZC pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 54a198ae7d0 Parse PostgreSQL altered column nullability (#39432)
54a198ae7d0 is described below
commit 54a198ae7d072655124e1276dc4bd7865d98a68c
Author: Cong Hu <ia...@gmail.com>
AuthorDate: Thu Aug 13 14:39:44 2026 +0800
Parse PostgreSQL altered column nullability (#39432)
* Parse PostgreSQL altered column nullability
WHAT: Preserve PostgreSQL ALTER TABLE ALTER COLUMN nullability metadata.
WHY: The grammar accepted SET and DROP NOT NULL, but the visitor always reported altered columns as nullable.
HOW: Detect SET NOT NULL in the existing AST and cover both SET and DROP forms.
* Add PostgreSQL altered column nullability release note
---
RELEASE-NOTES.md | 1 +
.../statement/type/PostgreSQLDDLStatementVisitor.java | 3 ++-
.../parser/src/main/resources/case/ddl/alter-table.xml | 18 ++++++++++++++++++
.../main/resources/sql/supported/ddl/alter-table.xml | 2 ++
4 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 9c212871b36..6088435b355 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -25,6 +25,7 @@
1. SQL Parser: Preserve openGauss `CREATE TABLE` column nullability metadata - [#39425](https://github.com/apache/shardingsphere/pull/39425)
1. SQL Parser: Preserve Hive `CREATE TABLE` column nullability metadata - [#39428](https://github.com/apache/shardingsphere/pull/39428)
1. SQL Parser: Preserve SQLServer `ALTER TABLE ALTER COLUMN` nullability metadata - [#39430](https://github.com/apache/shardingsphere/pull/39430)
+1. SQL Parser: Preserve PostgreSQL `ALTER TABLE ALTER COLUMN` nullability metadata - [#39432](https://github.com/apache/shardingsphere/pull/39432)
1. SQL Parser: Fix No value specified for parameter exception when sql is 'INSERT INTO tableName ON CONFLICT DO UPDATE set WHERE ' - [#38668](https://github.com/apache/shardingsphere/pull/38668)
1. SQL Binder: Add DialectFunctionOption to handle wrong skip column bind in ColumnSegmentBinder - [#38350](https://github.com/apache/shardingsphere/pull/38350)
1. SQL Binder: Fix wrong bind info when order by refer column from with temporary table - [#38353](https://github.com/apache/shardingsphere/pull/38353)
diff --git a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
index fb757289e68..becd7d92900 100644
--- a/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
+++ b/parser/sql/engine/dialect/postgresql/src/main/java/org/apache/shardingsphere/sql/parser/engine/postgresql/visitor/statement/type/PostgreSQLDDLStatementVisitor.java
@@ -620,7 +620,8 @@ public final class PostgreSQLDDLStatementVisitor extends PostgreSQLStatementVisi
// TODO visit pk and table ref
ColumnSegment column = (ColumnSegment) visit(ctx.modifyColumn().columnName());
DataTypeSegment dataType = null == ctx.dataType() ? null : (DataTypeSegment) visit(ctx.dataType());
- ColumnDefinitionSegment columnDefinition = new ColumnDefinitionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), column, dataType, false, false, getText(ctx));
+ boolean isNotNull = null != ctx.SET() && null != ctx.NOT() && null != ctx.NULL();
+ ColumnDefinitionSegment columnDefinition = new ColumnDefinitionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), column, dataType, false, isNotNull, getText(ctx));
return new ModifyColumnDefinitionSegment(ctx.getStart().getStartIndex(), ctx.getStop().getStopIndex(), columnDefinition);
}
diff --git a/test/it/parser/src/main/resources/case/ddl/alter-table.xml b/test/it/parser/src/main/resources/case/ddl/alter-table.xml
index 856c7d57802..5528dceacb2 100644
--- a/test/it/parser/src/main/resources/case/ddl/alter-table.xml
+++ b/test/it/parser/src/main/resources/case/ddl/alter-table.xml
@@ -1192,6 +1192,24 @@
</modify-column>
</alter-table>
+ <alter-table sql-case-id="alter_table_alter_column_set_not_null_postgresql">
+ <table name="t_order" start-index="12" stop-index="18" />
+ <modify-column>
+ <column-definition not-null="true" start-index="20" stop-index="52">
+ <column name="column4" />
+ </column-definition>
+ </modify-column>
+ </alter-table>
+
+ <alter-table sql-case-id="alter_table_alter_column_drop_not_null_postgresql">
+ <table name="t_order" start-index="12" stop-index="18" />
+ <modify-column>
+ <column-definition not-null="false" start-index="20" stop-index="53">
+ <column name="column4" />
+ </column-definition>
+ </modify-column>
+ </alter-table>
+
<alter-table sql-case-id="alter_table_alter_column_for_sqlserver">
<table name="t_order" start-index="12" stop-index="18" />
<modify-column>
diff --git a/test/it/parser/src/main/resources/sql/supported/ddl/alter-table.xml b/test/it/parser/src/main/resources/sql/supported/ddl/alter-table.xml
index 960c0dce527..e1b6b0dc86c 100644
--- a/test/it/parser/src/main/resources/sql/supported/ddl/alter-table.xml
+++ b/test/it/parser/src/main/resources/sql/supported/ddl/alter-table.xml
@@ -141,6 +141,8 @@
<sql-case id="alter_table_add_constraints_sqlserver" value="ALTER TABLE t_order_item ADD PRIMARY KEY (order_id), UNIQUE (order_id), CHECK (order_id > 0), FOREIGN KEY (order_id) REFERENCES t_order (order_id) ON UPDATE CASCADE ON DELETE CASCADE" db-types="SQLServer" />
<sql-case id="alter_table_drop_constraints_sqlserver" value="ALTER TABLE t_order DROP CONSTRAINT pk_order_id, uk_order_id, order_index" db-types="SQLServer" />
<sql-case id="alter_table_alter_column_for_postgresql" value="ALTER TABLE t_order ALTER column4 TYPE VARCHAR(20)" db-types="PostgreSQL,openGauss" />
+ <sql-case id="alter_table_alter_column_set_not_null_postgresql" value="ALTER TABLE t_order ALTER COLUMN column4 SET NOT NULL" db-types="PostgreSQL" />
+ <sql-case id="alter_table_alter_column_drop_not_null_postgresql" value="ALTER TABLE t_order ALTER COLUMN column4 DROP NOT NULL" db-types="PostgreSQL" />
<sql-case id="alter_table_alter_column_for_sqlserver" value="ALTER TABLE t_order ALTER COLUMN column4 VARCHAR(20)" db-types="SQLServer" />
<sql-case id="alter_table_alter_column_not_null_sqlserver" value="ALTER TABLE t_order ALTER COLUMN column4 VARCHAR(20) NOT NULL" db-types="SQLServer" />
<sql-case id="alter_table_alter_column_null_sqlserver" value="ALTER TABLE t_order ALTER COLUMN column4 VARCHAR(20) NULL" db-types="SQLServer" />