You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@beam.apache.org by jkff <gi...@git.apache.org> on 2017/04/29 03:15:12 UTC

[GitHub] beam pull request #2778: [BEAM-1402] AvroIO should comply with PTransform st...

GitHub user jkff opened a pull request:

    https://github.com/apache/beam/pull/2778

    [BEAM-1402] AvroIO should comply with PTransform style guide

    Migration guide:
    - AvroIO.Read.from(...).withSchema(Foo.class) -> AvroIO.read(Foo.class).from(...)
    - AvroIO.Read.from(...).withSchema(Schema or String) -> AvroIO.readGenericRecords(String).from(...)
    - Likewise for AvroIO.Write
    
    This is the last PR in https://issues.apache.org/jira/browse/BEAM-1353 !
    
    R: @reuvenlax 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jkff/incubator-beam avro-style

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/2778.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2778
    
----
commit b91f2b7291eccc1845e2e42eae36c8fa0acec25d
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T01:05:00Z

    Moves AvroSink to upper level

commit a9f7f1b474fda41fc663d94147e0d9fa94fe619b
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T01:19:21Z

    Removes AvroIO.Read.Bound

commit 7237c80bfa16716559e3d157481db55e8b025683
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T01:36:20Z

    Adds AvroIO.readGenericRecords()

commit c1a4d9bccc988c2b89d5501fe912d64e3832a98c
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T01:37:49Z

    Converts AvroIO.Read to AutoValue

commit ce17f5c39c4c0110db020922662b62b26e7f73ef
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T01:59:03Z

    Removes AvroIO.Write.Bound

commit 5a3f2c1ceac1528deef73fa21ad9db2e25bd3f96
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T02:03:25Z

    Moves AvroIO.Read.withSchema into read()

commit 8e883f02ff6f3b3abe0978e07a773f97e1b0d960
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T02:21:15Z

    Converts AvroIO.Write to AutoValue; adds writeGenericRecords()

commit 70fa3bd96d84a4e879a4fa05a188677311e93a24
Author: Eugene Kirpichov <ki...@google.com>
Date:   2017-04-29T02:25:45Z

    Moves AvroIO.write().withSchema into write()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #2778: [BEAM-1402] AvroIO should comply with PTransform st...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/beam/pull/2778


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---