[jira] [Commented] (SOLR-9385) add QParser.getParser(String,SolrQueryRequest) variant

["David Smiley (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-9385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15410419#comment-15410419 ] 

David Smiley commented on SOLR-9385:
------------------------------------

+1 love it!

getParser's javadocs refer to QParserPlugin.DEFAULT_QTYPE but it'd be more clear if in addition it stated it like {{"lucene" (QParserPlugin.DEFAULT_QTYPE)}} so it's immediately clear to anyone reading it without having to go chasing that constant down.

BTW, I anticipate you're going to add me to CHANGES.txt -- please don't.  IMO this feedback is too trivial to warrant it.

> add QParser.getParser(String,SolrQueryRequest) variant
> ------------------------------------------------------
>
>                 Key: SOLR-9385
>                 URL: https://issues.apache.org/jira/browse/SOLR-9385
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-9385.patch
>
>
> For a relative majority (~32) of callers this variant will eliminate the "What do i pass in for the default (since i do not have one)?" question, compared to a relative minority (~19) of callers that pass in a default other than the default.
> (Noticed as part of SOLR-8542 work.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org