You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/02/23 09:28:09 UTC

[PR] Revert recent changes to recoverWith [pekko]

pjfanning opened a new pull request, #2674:
URL: https://github.com/apache/pekko/pull/2674

   see #2620 and https://github.com/apache/pekko-http/issues/954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Revert recent changes to recoverWith [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #2674:
URL: https://github.com/apache/pekko/pull/2674


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Revert recent changes to recoverWith [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2674:
URL: https://github.com/apache/pekko/pull/2674#issuecomment-3946731178

   I will revert this if there are objections but in the short term, my aim is to fix the pekko-http build - https://github.com/apache/pekko-http/issues/954


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] Revert recent changes to recoverWith [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #2674:
URL: https://github.com/apache/pekko/pull/2674#issuecomment-3944100215

   Thanks @mdedetrich - it would be my aim to get this backported to 1.5 and appear in the next 1.x release. I agree that on the main branch that we can try to improve the code again but we do need to improve the test coverage to avoid breaking pekko-http http2 tests again. I hope to find some time this week to try to find specifically what is going wrong in pekko-http with the existing changes. I suspect that it is one of the 2 usages of recoverWithRetries that is being affected.
   https://github.com/search?q=repo%3Aapache%2Fpekko-http%20recoverWithRetries&type=code


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org