You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by bt...@apache.org on 2022/03/22 02:03:35 UTC

[james-project] 06/25: JAMES-3722 Remove no longer used parameters in AbstractSelectionProcessor

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 72596a00ec6e226e80fbe37a33ab27c2fe75700f
Author: Benoit Tellier <bt...@linagora.com>
AuthorDate: Mon Mar 7 23:40:34 2022 +0700

    JAMES-3722 Remove no longer used parameters in AbstractSelectionProcessor
---
 .../james/imap/processor/AbstractSelectionProcessor.java      | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
index 051755c..d6ad78a 100644
--- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
+++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java
@@ -98,9 +98,7 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ
     }
 
     private void respond(ImapSession session, MailboxPath fullMailboxPath, AbstractMailboxSelectionRequest request, Responder responder) throws MailboxException {
-
         ClientSpecifiedUidValidity lastKnownUidValidity = request.getLastKnownUidValidity();
-        Long modSeq = request.getKnownModSeq();
         IdRange[] knownSequences = request.getKnownSequenceSet();
         UidRange[] knownUids = request.getKnownUidSet();
 
@@ -157,10 +155,6 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ
         // The same is true if none are given ;)
         if (metaData.isModSeqPermanent() && !lastKnownUidValidity.isUnknown()) {
             if (lastKnownUidValidity.correspondsTo(metaData.getUidValidity())) {
-                
-                final MailboxManager mailboxManager = getMailboxManager();
-                final MailboxSession mailboxSession = session.getMailboxSession();
-                final MessageManager mailbox = mailboxManager.getMailbox(fullMailboxPath, mailboxSession);
 
                 //  If the provided UIDVALIDITY matches that of the selected mailbox, the
                 //  server then checks the last known modification sequence.
@@ -168,7 +162,6 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ
                 //  The server sends the client any pending flag changes (using FETCH
                 //  responses that MUST contain UIDs) and expunges those that have
                 //  occurred in this mailbox since the provided modification sequence.
-
                 UidRange[] uidSet = request.getUidSet();
 
                 if (uidSet == null) {
@@ -181,7 +174,7 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ
                 }
                 
                 if (uidSet != null) {
-                    respondVanished(session, responder, modSeq, knownSequences, knownUids, metaData, selected, mailboxSession, mailbox, uidSet);
+                    respondVanished(session, responder, knownSequences, knownUids, selected, uidSet);
                 }
                 taggedOk(responder, request, metaData, HumanReadableText.SELECT);
             } else {
@@ -197,7 +190,7 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ
         SearchResUtil.resetSavedSequenceSet(session);
     }
 
-    private void respondVanished(ImapSession session, Responder responder, Long modSeq, IdRange[] knownSequences, UidRange[] knownUids, MailboxMetaData metaData, SelectedMailbox selected, MailboxSession mailboxSession, MessageManager mailbox, UidRange[] uidSet) throws MailboxException {
+    private void respondVanished(ImapSession session, Responder responder, IdRange[] knownSequences, UidRange[] knownUids, SelectedMailbox selected, UidRange[] uidSet) throws MailboxException {
         // RFC5162 3.1. QRESYNC Parameter to SELECT/EXAMINE
         //
         // Message sequence match data:

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org