You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alex Clemmer <cl...@gmail.com> on 2016/11/28 18:55:41 UTC
Re: Review Request 53757: CMake: Moved logrotate container logger
binary build definition.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53757/#review157103
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Clemmer
On Nov. 15, 2016, 10:56 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53757/
> -----------------------------------------------------------
>
> (Updated Nov. 15, 2016, 10:56 p.m.)
>
>
> Review request for mesos, Alex Clemmer and Joris Van Remoortere.
>
>
> Bugs: MESOS-5792
> https://issues.apache.org/jira/browse/MESOS-5792
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This was originally included at a higher level. Per CMake style,
> build files should generally be included in the CMakeLists.txt file
> located in the same directory.
>
>
> Diffs
> -----
>
> src/slave/CMakeLists.txt 33120ace79bce449329a7cc4b7ef264d2867fc13
> src/slave/container_loggers/CMakeLists.txt PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53757/diff/
>
>
> Testing
> -------
>
> cmake ..
> make
>
>
> Thanks,
>
> Joseph Wu
>
>