You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by Oleg Kalnichevski <ol...@apache.org> on 2026/08/02 13:15:44 UTC

Re: (httpcomponents-core) branch master updated: Tabs -> spaces (was not picked up by a local default Maven build).

On Sun, 2026-08-02 at 12:51 +0000, ggregory@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
> 
> garydgregory pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/httpcomponents-core.git
> 
> 
> The following commit(s) were added to refs/heads/master by this push:
>      new 5230fc112 Tabs -> spaces (was not picked up by a local
> default Maven build).
> 5230fc112 is described below
> 
> commit 5230fc1122aa58b28e526064c018b041ce3bc3d2
> Author: Gary Gregory <ga...@gmail.com>
> AuthorDate: Sun Aug 2 08:51:03 2026 -0400
> 

Hi Gary

Please try to avoid unnecessary commit noise. Things are already hard
as they are. 

Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: (httpcomponents-core) branch master updated: Tabs -> spaces (was not picked up by a local default Maven build).

Posted by Oleg Kalnichevski <ol...@apache.org>.
On Sun, 2026-08-02 at 10:27 -0400, Gary Gregory wrote:
> On Sun, Aug 2, 2026 at 9:15 AM Oleg Kalnichevski <ol...@apache.org>
> wrote:
> > 
> > On Sun, 2026-08-02 at 12:51 +0000, ggregory@apache.org wrote:
> > > This is an automated email from the ASF dual-hosted git
> > > repository.
> > > 
> > > garydgregory pushed a commit to branch master
> > > in repository
> > > https://gitbox.apache.org/repos/asf/httpcomponents-core.git
> > > 
> > > 
> > > The following commit(s) were added to refs/heads/master by this
> > > push:
> > >      new 5230fc112 Tabs -> spaces (was not picked up by a local
> > > default Maven build).
> > > 5230fc112 is described below
> > > 
> > > commit 5230fc1122aa58b28e526064c018b041ce3bc3d2
> > > Author: Gary Gregory <ga...@gmail.com>
> > > AuthorDate: Sun Aug 2 08:51:03 2026 -0400
> > > 
> > 
> > Hi Gary
> > 
> > Please try to avoid unnecessary commit noise. Things are already
> > hard
> > as they are.
> 
> Indeed, what I don't understand is why a default Maven build
> passed...
> 

The stylecheck has always been very deterministic, predictable and
reliable in my experience. I have a bit of a problem coming up with a
rational explanation for the same style check passing locally and
failing at GH. But maybe this is something specific to your local
environment and it would be great to find the root cause of it.

Anyways, here is what I recommend doing in order to avoid problems like
that in principle:

1. Have two remotes defined, `origin` pointing at the official ASF repo
and `private` pointing at your own private fork of the official repo.

2. Push the change-set to your private repo first (force push)

3. Make sure GH Action completes and its status is green

4. Only then push the same change-set to origin 


```
oleg@ok2c:~/src/apache.org/httpcomponents/httpcore
$ git remote -v
origin	git@github.com:apache/httpcomponents-core.git (fetch)
origin	git@github.com:apache/httpcomponents-core.git (push)
private	git@github.com:ok2c/httpcomponents-core.git (fetch)
private	git@github.com:ok2c/httpcomponents-core.git (push)
oleg@ok2c:~/src/apache.org/httpcomponents/httpcore
$ git push private master -f
Total 0 (delta 0), reused 0 (delta 0), pack-reused 0 (from 0)
To github.com:ok2c/httpcomponents-core.git
   598ab6582..da423c9d8  master -> master
oleg@ok2c:~/src/apache.org/httpcomponents/httpcore
```
Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Re: (httpcomponents-core) branch master updated: Tabs -> spaces (was not picked up by a local default Maven build).

Posted by Gary Gregory <ga...@gmail.com>.
On Sun, Aug 2, 2026 at 9:15 AM Oleg Kalnichevski <ol...@apache.org> wrote:
>
> On Sun, 2026-08-02 at 12:51 +0000, ggregory@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > garydgregory pushed a commit to branch master
> > in repository
> > https://gitbox.apache.org/repos/asf/httpcomponents-core.git
> >
> >
> > The following commit(s) were added to refs/heads/master by this push:
> >      new 5230fc112 Tabs -> spaces (was not picked up by a local
> > default Maven build).
> > 5230fc112 is described below
> >
> > commit 5230fc1122aa58b28e526064c018b041ce3bc3d2
> > Author: Gary Gregory <ga...@gmail.com>
> > AuthorDate: Sun Aug 2 08:51:03 2026 -0400
> >
>
> Hi Gary
>
> Please try to avoid unnecessary commit noise. Things are already hard
> as they are.

Indeed, what I don't understand is why a default Maven build passed...

Gary

>
> Oleg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org