Re: [PR] GCP: KeyManagementClient implementation that works with Google Cloud KMS [iceberg]

["szlta (via GitHub)" <gi...@apache.org>]

szlta commented on code in PR #13334:
URL: https://github.com/apache/iceberg/pull/13334#discussion_r2251514077


##########
gcp-bundle/build.gradle:
##########
@@ -28,6 +28,7 @@ project(":iceberg-gcp-bundle") {
     implementation "com.google.cloud:google-cloud-storage"
     implementation "com.google.cloud:google-cloud-bigquery"
     implementation "com.google.cloud:google-cloud-core"
+    implementation "com.google.cloud:google-cloud-kms"

Review Comment:
   Update: I enhanced the current implementation so that it can work with both shaded and non-shaded protobuf dependencies. It now uses `DynMethods` and `DynClasses` utils to load the methods in a dynamic way. If the relocated class is observed it will be preferred over the original class name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org