You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/09/27 12:15:16 UTC
[GitHub] [incubator-nuttx] fjpanag opened a new pull request, #7201: Fixed non-UTF8 characters.
fjpanag opened a new pull request, #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201
## Summary
Fixed several non-UTF8 characters throughout the source code.
## Impact
N/A
## Testing
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a diff in pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on code in PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#discussion_r981338869
##########
arch/arm/src/armv7-a/arm.h:
##########
@@ -19,10 +19,10 @@
****************************************************************************/
/* References:
- * "Cortex-A5� MPCore, Technical Reference Manual", Revision: r0p1,
- * Copyright � 2010 ARM. All rights reserved. ARM DDI 0434B (ID101810)
- * "ARM� Architecture Reference Manual, ARMv7-A and ARMv7-R edition",
- * Copyright � 1996-1998, 2000, 2004-2012 ARM. All rights reserved.
+ * "Cortex-A5™ MPCore, Technical Reference Manual", Revision: r0p1,
Review Comment:
I think so? What do you thing is the problem?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259552862
@xiaoxiang781216 I will take a look on the style errors.
I will run the tool on `apps/` too.
Can you help with the CI script?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#discussion_r981297351
##########
arch/arm/src/armv7-a/arm.h:
##########
@@ -19,10 +19,10 @@
****************************************************************************/
/* References:
- * "Cortex-A5� MPCore, Technical Reference Manual", Revision: r0p1,
- * Copyright � 2010 ARM. All rights reserved. ARM DDI 0434B (ID101810)
- * "ARM� Architecture Reference Manual, ARMv7-A and ARMv7-R edition",
- * Copyright � 1996-1998, 2000, 2004-2012 ARM. All rights reserved.
+ * "Cortex-A5™ MPCore, Technical Reference Manual", Revision: r0p1,
Review Comment:
is this conversion right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#discussion_r981861061
##########
arch/arm/src/armv7-a/arm.h:
##########
@@ -19,10 +19,10 @@
****************************************************************************/
/* References:
- * "Cortex-A5� MPCore, Technical Reference Manual", Revision: r0p1,
- * Copyright � 2010 ARM. All rights reserved. ARM DDI 0434B (ID101810)
- * "ARM� Architecture Reference Manual, ARMv7-A and ARMv7-R edition",
- * Copyright � 1996-1998, 2000, 2004-2012 ARM. All rights reserved.
+ * "Cortex-A5™ MPCore, Technical Reference Manual", Revision: r0p1,
Review Comment:
it looks good on my smart phone, but wrong on my PC. The locale config may have some problem in my PC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259440496
@fjpanag nice! How did you search for non-UTF8 chars?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259572214
BTW the warning `Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/a1x/hardware/a10_memorymap.h:289:1: warning: #include outside of 'Included Files' section` is a false alarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259556624
> @xiaoxiang781216 I will take a look on the style errors. I will run the tool on `apps/` too.
>
> Can you help with the CI script?
sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259446094
> @fjpanag nice! How did you search for non-UTF8 chars?
I used `cvt2utf` to do the conversion.
Is it possible to include this in CI, so non-UTF8 characters are no more introduced in the codebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259531212
@fjpanag let's fix the follow style issue?
```
Warning: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/a1x/hardware/a10_memorymap.h:289:1: warning: #include outside of 'Included Files' section
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/lpc31xx/ea3[13](https://github.com/apache/incubator-nuttx/actions/runs/3135514943/jobs/5091280431#step:3:14)1/src/lpc31_mem.c:106:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/lpc31xx/ea3152/src/lpc31_mem.c:106:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/sama5/sama5d3-xplained/src/sam_ethernet.c:169:79: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/sama5/sama5d3-xplained/src/sam_sdram.c:[14](https://github.com/apache/incubator-nuttx/actions/runs/3135514943/jobs/5091280431#step:3:15)0:78: error: Long line found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/boards/arm/sama5/sama5d3x-ek/src/sam_ethernet.c:[16](https://github.com/apache/incubator-nuttx/actions/runs/3135514943/jobs/5091280431#step:3:17)9:79: error: Long line found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #7201: Fixed non-UTF8 characters.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #7201:
URL: https://github.com/apache/incubator-nuttx/pull/7201#issuecomment-1259526283
> > @fjpanag nice! How did you search for non-UTF8 chars?
>
> I used `cvt2utf` to do the conversion.
>
> Is it possible to include this in CI, so non-UTF8 characters are no more introduced in the codebase?
it's good ideal to add some guard in CI. BTW, should we apply the same change to apps/ folder too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org