You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/10/16 20:48:23 UTC
[GitHub] michellethomas opened a new pull request #3679: Avoid dividing by zero for sparkline in time table viz
michellethomas opened a new pull request #3679: Avoid dividing by zero for sparkline in time table viz
URL: https://github.com/apache/incubator-superset/pull/3679
When calculating ratios to add to the sparkline, we should not be dividing by zero or null values. Instead I'm passing a null value to sparkData. This will result in a blank space in the sparkline. This matches how the line chart handles dividing by zero or null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services