You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "yyqdbngt (via GitHub)" <gi...@apache.org> on 2026/09/05 13:30:37 UTC

[PR] fix(persistence): hide data source config json from toString [rocketmq-dashboard]

yyqdbngt opened a new pull request, #3351:
URL: https://github.com/apache/rocketmq-dashboard/pull/3351

   ## Summary
   
   Marks the persisted data-source row's `json` (resolved config, which can embed passwords and bearer tokens) as `@ToString.Exclude`, matching the existing `RmqSettings` convention, and adds `RmqDataSourceTest` locking the contract.
   
   Coverage:
   - `toString` keeps the non-secret key (`dsKey`) while omitting both the `json` field name and any embedded secret values;
   - `@Data` equality/hashCode still cover the json payload, so a changed configuration is not equal.
   
   ## Why
   
   The entity is logged during data-source connectivity operations; the serialized config JSON can contain credentials, so it must not surface through `toString`.
   
   ## Testing
   
   `mvn -B test -Dtest=RmqDataSourceTest` — 2/2 pass; checkstyle (validate) clean.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(persistence): hide data source config json from toString [rocketmq-dashboard]

Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins closed pull request #3351: fix(persistence): hide data source config json from toString
URL: https://github.com/apache/rocketmq-dashboard/pull/3351


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org