[GitHub] [iceberg] stevenzwu commented on a diff in pull request #8170: Doc: update Flink get started instruction for 1.16+ due to regression of loading external jar

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on code in PR #8170:
URL: https://github.com/apache/iceberg/pull/8170#discussion_r1280744086


##########
docs/flink-getting-started.md:
##########
@@ -83,7 +83,12 @@ Start the Flink SQL client. There is a separate `flink-runtime` module in the Ic
 # HADOOP_HOME is your hadoop root directory after unpack the binary package.
 export HADOOP_CLASSPATH=`$HADOOP_HOME/bin/hadoop classpath`   
 
+# Below works for 1.15 or less
 ./bin/sql-client.sh embedded -j <flink-runtime-directory>/iceberg-flink-runtime-1.16-{{% icebergVersion %}}.jar shell

Review Comment:
   good catch. fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org