You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2020/11/03 21:23:00 UTC
[tomcat] branch master updated: Workaround what looks like a JRE
bug to me
This is an automated email from the ASF dual-hosted git repository.
markt pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new a958480 Workaround what looks like a JRE bug to me
a958480 is described below
commit a9584808041497015cd6dbb4b098096a264fe18e
Author: Mark Thomas <ma...@apache.org>
AuthorDate: Tue Nov 3 21:22:34 2020 +0000
Workaround what looks like a JRE bug to me
https://bugs.openjdk.java.net/browse/JDK-8255854
---
java/org/apache/el/stream/package-info.java | 18 ++++++++++++++++++
java/org/apache/el/util/package-info.java | 18 ++++++++++++++++++
res/bnd/jasper-el.jar.tmp.bnd | 2 +-
3 files changed, 37 insertions(+), 1 deletion(-)
diff --git a/java/org/apache/el/stream/package-info.java b/java/org/apache/el/stream/package-info.java
new file mode 100644
index 0000000..7af866a
--- /dev/null
+++ b/java/org/apache/el/stream/package-info.java
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+@aQute.bnd.annotation.jpms.Open
+package org.apache.el.stream;
\ No newline at end of file
diff --git a/java/org/apache/el/util/package-info.java b/java/org/apache/el/util/package-info.java
new file mode 100644
index 0000000..a490094
--- /dev/null
+++ b/java/org/apache/el/util/package-info.java
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+//@aQute.bnd.annotation.jpms.Open
+package org.apache.el.util;
\ No newline at end of file
diff --git a/res/bnd/jasper-el.jar.tmp.bnd b/res/bnd/jasper-el.jar.tmp.bnd
index 67a2384..d9e97fb 100644
--- a/res/bnd/jasper-el.jar.tmp.bnd
+++ b/res/bnd/jasper-el.jar.tmp.bnd
@@ -30,7 +30,7 @@ Export-Package: \
-jpms-module-info: \
${module.name};\
- access=32;\
+ access=0;\
version=${Bundle-Version}
-jpms-module-info-options: \
${module.name};\
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated: Workaround what looks like a JRE
bug to me
Posted by Mark Thomas <ma...@apache.org>.
On 03/11/2020 21:33, Mark Thomas wrote:
> On 03/11/2020 21:23, markt@apache.org wrote:
>> This is an automated email from the ASF dual-hosted git repository.
>>
>> markt pushed a commit to branch master
>> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>>
>>
>> The following commit(s) were added to refs/heads/master by this push:
>> new a958480 Workaround what looks like a JRE bug to me
>
> With thanks to rotty3000 for helping me get my head around
> module-info.class.
Details at: https://bugs.openjdk.java.net/browse/JDK-8255854
Note my initial analysis was wrong. Skip to the final comment for the
(hopefully) correct analysis.
Assuming the analysis is correct, still need to figure out the best way
to handle this in Tomcat.
Mark
>
>
>> a958480 is described below
>>
>> commit a9584808041497015cd6dbb4b098096a264fe18e
>> Author: Mark Thomas <ma...@apache.org>
>> AuthorDate: Tue Nov 3 21:22:34 2020 +0000
>>
>> Workaround what looks like a JRE bug to me
>>
>> https://bugs.openjdk.java.net/browse/JDK-8255854
>> ---
>> java/org/apache/el/stream/package-info.java | 18 ++++++++++++++++++
>> java/org/apache/el/util/package-info.java | 18 ++++++++++++++++++
>
> The above file is actually for the next work-around but I'll leave it in
> the repo as I'll need it shortly. Just want to get to the bottom of why
> it is required before I apply it in case there is another JRE bug.
>
> Mark
>
>
>> res/bnd/jasper-el.jar.tmp.bnd | 2 +-
>> 3 files changed, 37 insertions(+), 1 deletion(-)
>>
>> diff --git a/java/org/apache/el/stream/package-info.java b/java/org/apache/el/stream/package-info.java
>> new file mode 100644
>> index 0000000..7af866a
>> --- /dev/null
>> +++ b/java/org/apache/el/stream/package-info.java
>> @@ -0,0 +1,18 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +@aQute.bnd.annotation.jpms.Open
>> +package org.apache.el.stream;
>> \ No newline at end of file
>> diff --git a/java/org/apache/el/util/package-info.java b/java/org/apache/el/util/package-info.java
>> new file mode 100644
>> index 0000000..a490094
>> --- /dev/null
>> +++ b/java/org/apache/el/util/package-info.java
>> @@ -0,0 +1,18 @@
>> +/*
>> + * Licensed to the Apache Software Foundation (ASF) under one or more
>> + * contributor license agreements. See the NOTICE file distributed with
>> + * this work for additional information regarding copyright ownership.
>> + * The ASF licenses this file to You under the Apache License, Version 2.0
>> + * (the "License"); you may not use this file except in compliance with
>> + * the License. You may obtain a copy of the License at
>> + *
>> + * http://www.apache.org/licenses/LICENSE-2.0
>> + *
>> + * Unless required by applicable law or agreed to in writing, software
>> + * distributed under the License is distributed on an "AS IS" BASIS,
>> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
>> + * See the License for the specific language governing permissions and
>> + * limitations under the License.
>> + */
>> +//@aQute.bnd.annotation.jpms.Open
>> +package org.apache.el.util;
>> \ No newline at end of file
>> diff --git a/res/bnd/jasper-el.jar.tmp.bnd b/res/bnd/jasper-el.jar.tmp.bnd
>> index 67a2384..d9e97fb 100644
>> --- a/res/bnd/jasper-el.jar.tmp.bnd
>> +++ b/res/bnd/jasper-el.jar.tmp.bnd
>> @@ -30,7 +30,7 @@ Export-Package: \
>>
>> -jpms-module-info: \
>> ${module.name};\
>> - access=32;\
>> + access=0;\
>> version=${Bundle-Version}
>> -jpms-module-info-options: \
>> ${module.name};\
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
>> For additional commands, e-mail: dev-help@tomcat.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [tomcat] branch master updated: Workaround what looks like a JRE
bug to me
Posted by Mark Thomas <ma...@apache.org>.
On 03/11/2020 21:23, markt@apache.org wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> markt pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
> new a958480 Workaround what looks like a JRE bug to me
With thanks to rotty3000 for helping me get my head around
module-info.class.
> a958480 is described below
>
> commit a9584808041497015cd6dbb4b098096a264fe18e
> Author: Mark Thomas <ma...@apache.org>
> AuthorDate: Tue Nov 3 21:22:34 2020 +0000
>
> Workaround what looks like a JRE bug to me
>
> https://bugs.openjdk.java.net/browse/JDK-8255854
> ---
> java/org/apache/el/stream/package-info.java | 18 ++++++++++++++++++
> java/org/apache/el/util/package-info.java | 18 ++++++++++++++++++
The above file is actually for the next work-around but I'll leave it in
the repo as I'll need it shortly. Just want to get to the bottom of why
it is required before I apply it in case there is another JRE bug.
Mark
> res/bnd/jasper-el.jar.tmp.bnd | 2 +-
> 3 files changed, 37 insertions(+), 1 deletion(-)
>
> diff --git a/java/org/apache/el/stream/package-info.java b/java/org/apache/el/stream/package-info.java
> new file mode 100644
> index 0000000..7af866a
> --- /dev/null
> +++ b/java/org/apache/el/stream/package-info.java
> @@ -0,0 +1,18 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +@aQute.bnd.annotation.jpms.Open
> +package org.apache.el.stream;
> \ No newline at end of file
> diff --git a/java/org/apache/el/util/package-info.java b/java/org/apache/el/util/package-info.java
> new file mode 100644
> index 0000000..a490094
> --- /dev/null
> +++ b/java/org/apache/el/util/package-info.java
> @@ -0,0 +1,18 @@
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one or more
> + * contributor license agreements. See the NOTICE file distributed with
> + * this work for additional information regarding copyright ownership.
> + * The ASF licenses this file to You under the Apache License, Version 2.0
> + * (the "License"); you may not use this file except in compliance with
> + * the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing, software
> + * distributed under the License is distributed on an "AS IS" BASIS,
> + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
> + * See the License for the specific language governing permissions and
> + * limitations under the License.
> + */
> +//@aQute.bnd.annotation.jpms.Open
> +package org.apache.el.util;
> \ No newline at end of file
> diff --git a/res/bnd/jasper-el.jar.tmp.bnd b/res/bnd/jasper-el.jar.tmp.bnd
> index 67a2384..d9e97fb 100644
> --- a/res/bnd/jasper-el.jar.tmp.bnd
> +++ b/res/bnd/jasper-el.jar.tmp.bnd
> @@ -30,7 +30,7 @@ Export-Package: \
>
> -jpms-module-info: \
> ${module.name};\
> - access=32;\
> + access=0;\
> version=${Bundle-Version}
> -jpms-module-info-options: \
> ${module.name};\
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org