You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by David E Jones <jo...@undersunconsulting.com> on 2008/09/14 22:59:54 UTC
Re: svn commit: r695286 - /ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
I hope it was more of a request than a demand, but either way thank
you for doing that Jacques.
-David
On Sep 14, 2008, at 2:49 PM, jleroux@apache.org wrote:
> Author: jleroux
> Date: Sun Sep 14 13:49:20 2008
> New Revision: 695286
>
> URL: http://svn.apache.org/viewvc?rev=695286&view=rev
> Log:
> Revert commits 695268/695281 related to OFBIZ-1955 at David and
> Jacopo's demands
>
> Modified:
> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/
> customer/CustomerEvents.xml
>
> Modified: ofbiz/trunk/applications/ecommerce/script/org/ofbiz/
> ecommerce/customer/CustomerEvents.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=695286&r1=695285&r2=695286&view=diff
> =
> =
> =
> =
> =
> =
> =
> =
> ======================================================================
> --- ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/
> customer/CustomerEvents.xml (original)
> +++ ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/
> customer/CustomerEvents.xml Sun Sep 14 13:49:20 2008
> @@ -307,13 +307,6 @@
> <create-value value-name="partyDataSource"/>
> <call-service service-name="createPartyRole" in-map-
> name="partyRoleContext" include-user-login="true"/>
>
> - <!-- Create party relationship between the new customer
> and the product store sales representative -->
> - <set field="partyRelationshipCtx.partyIdTo" value="admin"/>
> - <set field="partyRelationshipCtx.roleTypeIdTo"
> value="SALES_REP"/>
> - <set field="partyRelationshipCtx.roleTypeIdFrom"
> value="CUSTOMER"/>
> - <set field="partyRelationshipCtx.partyRelationshipTypeId"
> value="DISTRIBUTION_CHANNEL"/>
> - <call-service service-name="createPartyRelationship" in-map-
> name="partyRelationshipCtx"/>
> -
> <!-- shipping address -->
> <if-compare field="parameters.USE_ADDRESS" operator="equals"
> value="false">
> <!-- address not used, do nothing -->
>
>
Re: svn commit: r695286 - /ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml
Posted by Jacques Le Roux <ja...@les7arts.com>.
Don't worry, I took it as a request. In French "une demande" is more like "a request" in English that's why I often use this false
friend.
I just wonder what's wrong, apart admin harcoded of course. For that I suggested to use ProductStoreRole and SALES_REP to retrieve
the right person (Party). There should be always one I believe. I can't think of a store without someone responsible.
I think it could be interesting to have this as a kind of example to use createPartyRelationship.
There are some other examples like in createEmployee, which is not very different. Why not this new one ? Do you think it's useless
in most cases or even worse ?
Jacques
From: "David E Jones" <jo...@undersunconsulting.com>
>
> I hope it was more of a request than a demand, but either way thank you for doing that Jacques.
>
> -David
>
>
> On Sep 14, 2008, at 2:49 PM, jleroux@apache.org wrote:
>
>> Author: jleroux
>> Date: Sun Sep 14 13:49:20 2008
>> New Revision: 695286
>>
>> URL: http://svn.apache.org/viewvc?rev=695286&view=rev
>> Log:
>> Revert commits 695268/695281 related to OFBIZ-1955 at David and Jacopo's demands
>>
>> Modified:
>> ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/ customer/CustomerEvents.xml
>>
>> Modified: ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ ecommerce/customer/CustomerEvents.xml
>> URL:
>> http://svn.apache.org/viewvc/ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/customer/CustomerEvents.xml?rev=695286&r1=695285&r2=695286&view=diff
>> = = = = = = = = ======================================================================
>> --- ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/ customer/CustomerEvents.xml (original)
>> +++ ofbiz/trunk/applications/ecommerce/script/org/ofbiz/ecommerce/ customer/CustomerEvents.xml Sun Sep 14 13:49:20 2008
>> @@ -307,13 +307,6 @@
>> <create-value value-name="partyDataSource"/>
>> <call-service service-name="createPartyRole" in-map- name="partyRoleContext" include-user-login="true"/>
>>
>> - <!-- Create party relationship between the new customer and the product store sales representative -->
>> - <set field="partyRelationshipCtx.partyIdTo" value="admin"/>
>> - <set field="partyRelationshipCtx.roleTypeIdTo" value="SALES_REP"/>
>> - <set field="partyRelationshipCtx.roleTypeIdFrom" value="CUSTOMER"/>
>> - <set field="partyRelationshipCtx.partyRelationshipTypeId" value="DISTRIBUTION_CHANNEL"/>
>> - <call-service service-name="createPartyRelationship" in-map- name="partyRelationshipCtx"/>
>> -
>> <!-- shipping address -->
>> <if-compare field="parameters.USE_ADDRESS" operator="equals" value="false">
>> <!-- address not used, do nothing -->
>>
>>
>