You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/05/27 06:48:18 UTC

[GitHub] [cloudstack-documentation] harikrishna-patnala opened a new pull request, #273: Added documentation for the first class resource userdata

harikrishna-patnala opened a new pull request, #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273

   This documentation is related to the changes made in PR https://github.com/apache/cloudstack/pull/6202.
   
   Following are the changes made.
   1. Userdata registration, listing and deleting under "Compute" tab
   2. Providing registered userdata in "Add Instance" form
   3. Linking userdata to template while registering/uploading/editing of a template/ISO
   4. Explaining the userdata override policy while linking userdata to template


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] weizhouapache commented on a diff in pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#discussion_r886391429


##########
source/adminguide/virtual_machines/user-data.rst:
##########
@@ -47,6 +47,27 @@ To register a new userdata:
    :align: center
    :alt: Regiser userdata dialog box
 
+If userdata content has variables declared in it, user can register the Userdata
+with userdata parameters.
+
+For example, if userdata content is like below having a custom variable "variable1"
+   .. code:: bash
+      ## template: jinja
+      #cloud-config
+      runcmd:
+         - echo 'TestVariable {{ ds.meta_data.variable1 }}' >> /tmp/variable
+         - echo 'Hostname {{ ds.meta_data.public_hostname }}' > /tmp/hostname

Review Comment:
   @harikrishna-patnala 
   thanks for the update.
   
   strange I cannot see this piece of code in doc. 
   http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273/adminguide/virtual_machines/user-data.html



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] harikrishna-patnala commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143183941

   > code lgtm checked http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273/adminguide/templates.html http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273/adminguide/virtual_machines/user-data.html
   > 
   > @harikrishna-patnala would it be good to add a section to decribe how to use userdata parameters in cloud-config/jinja template ?
   
   Thanks for the review @weizhouapache. I've now added them in the flow of userdata registration and during vm deployment. Please review again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] harikrishna-patnala commented on a diff in pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#discussion_r886424527


##########
source/adminguide/virtual_machines/user-data.rst:
##########
@@ -47,6 +47,27 @@ To register a new userdata:
    :align: center
    :alt: Regiser userdata dialog box
 
+If userdata content has variables declared in it, user can register the Userdata
+with userdata parameters.
+
+For example, if userdata content is like below having a custom variable "variable1"
+   .. code:: bash
+      ## template: jinja
+      #cloud-config
+      runcmd:
+         - echo 'TestVariable {{ ds.meta_data.variable1 }}' >> /tmp/variable
+         - echo 'Hostname {{ ds.meta_data.public_hostname }}' > /tmp/hostname

Review Comment:
   a space was missing. fixed it @weizhouapache 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143198009

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143236138

   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273. (SL-JID 253)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143227516

   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273. (SL-JID 252)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] harikrishna-patnala commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143232038

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143199442

   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273. (SL-JID 251)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] harikrishna-patnala commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143224369

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143234891

   @harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143198263

   @weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] weizhouapache commented on a diff in pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#discussion_r886518340


##########
source/adminguide/virtual_machines/user-data.rst:
##########
@@ -47,6 +47,27 @@ To register a new userdata:
    :align: center
    :alt: Regiser userdata dialog box
 
+If userdata content has variables declared in it, user can register the Userdata
+with userdata parameters.
+
+For example, if userdata content is like below having a custom variable "variable1"
+   .. code:: bash
+      ## template: jinja
+      #cloud-config
+      runcmd:
+         - echo 'TestVariable {{ ds.meta_data.variable1 }}' >> /tmp/variable
+         - echo 'Hostname {{ ds.meta_data.public_hostname }}' > /tmp/hostname

Review Comment:
   good. @harikrishna-patnala 
   verified oK



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1141413714

   Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273. (SL-JID 250)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] rohityadavcloud merged pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1141451897

   code lgtm
   checked
   http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273/adminguide/templates.html
   http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/273/adminguide/virtual_machines/user-data.html
   
   @harikrishna-patnala 
   would it be good to add a section to decribe how to use userdata parameters in cloud-config/jinja template ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1141413166

   @weizhouapache a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] weizhouapache commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1141412565

   @blueorangutan docbuild


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [cloudstack-documentation] blueorangutan commented on pull request #273: Added documentation for the first class resource userdata

Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #273:
URL: https://github.com/apache/cloudstack-documentation/pull/273#issuecomment-1143225737

   @harikrishna-patnala a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org