You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/11/28 15:08:14 UTC

[GitHub] [kafka] chia7712 opened a new pull request #11545: MINOR: replace Thread.isAlive by Thread.is_alive for Python code

chia7712 opened a new pull request #11545:
URL: https://github.com/apache/kafka/pull/11545


   `Thread.isAlive` was removed from python 3.9 (see https://bugs.python.org/issue37804), and the default version of python 3 in `openjdk:8` image is `3.9.2`. Hence, the following error is produced when running system tests.
   
   ```
   Traceback (most recent call last):
     File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 133, in run
       data = self.run_test()
     File "/usr/local/lib/python3.9/dist-packages/ducktape/tests/runner_client.py", line 190, in run_test
       return self.test_context.function(self.test)
     File "/usr/local/lib/python3.9/dist-packages/ducktape/mark/_mark.py", line 429, in wrapper
       return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
     File "/opt/kafka-dev/tests/kafkatest/tests/client/quota_test.py", line 157, in test_quota
       producer.run()
     File "/usr/local/lib/python3.9/dist-packages/ducktape/services/service.py", line 318, in run
       self.stop()
     File "/opt/kafka-dev/tests/kafkatest/services/monitor/http.py", line 97, in stop
       super(HttpMetricsCollector, self).stop()
     File "/usr/local/lib/python3.9/dist-packages/ducktape/services/background_thread.py", line 84, in stop
       super(BackgroundThreadService, self).stop()
     File "/usr/local/lib/python3.9/dist-packages/ducktape/services/service.py", line 281, in stop
       self.stop_node(node)
     File "/opt/kafka-dev/tests/kafkatest/services/monitor/http.py", line 109, in stop_node
       self._forwarders[idx].stop()
     File "/opt/kafka-dev/tests/kafkatest/services/monitor/http.py", line 191, in stop
       if self._accept_thread.isAlive():
   AttributeError: 'Thread' object has no attribute 'isAlive'
   ```
   
   The replacement is `Thread.is_alive`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [kafka] chia7712 merged pull request #11545: MINOR: replace Thread.isAlive by Thread.is_alive for Python code

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #11545:
URL: https://github.com/apache/kafka/pull/11545


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org