You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2024/06/23 12:35:13 UTC
(commons-fileupload) branch master updated (7abbb878 -> 4c9de33a)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
from 7abbb878 Bump github/codeql-action from 3.25.8 to 3.25.10 (#323)
new 5c82e344 Fix PMD UnnecessaryFullyQualifiedName
new 36e12f99 Add missing Javadoc for generics
new 4c9de33a Add missing Javadoc for generics
The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../org/apache/commons/fileupload2/core/DiskFileItem.java | 2 +-
.../org/apache/commons/fileupload2/core/MultipartInput.java | 12 +++++++-----
pom.xml | 2 +-
3 files changed, 9 insertions(+), 7 deletions(-)
(commons-fileupload) 03/03: Add missing Javadoc for generics
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 4c9de33ab64394585609b86d6405900457d53263
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jun 23 08:30:10 2024 -0400
Add missing Javadoc for generics
---
pom.xml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/pom.xml b/pom.xml
index df920783..4e6a8f02 100644
--- a/pom.xml
+++ b/pom.xml
@@ -21,7 +21,7 @@
<parent>
<groupId>org.apache.commons</groupId>
<artifactId>commons-parent</artifactId>
- <version>69</version>
+ <version>71</version>
</parent>
<artifactId>commons-fileupload2</artifactId>
(commons-fileupload) 02/03: Add missing Javadoc for generics
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 36e12f991faab9933cb43556105a9f19717b80c7
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jun 23 08:29:49 2024 -0400
Add missing Javadoc for generics
---
.../org/apache/commons/fileupload2/core/MultipartInput.java | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/MultipartInput.java b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/MultipartInput.java
index e9fe4291..e90b8d60 100644
--- a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/MultipartInput.java
+++ b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/MultipartInput.java
@@ -258,14 +258,16 @@ public final class MultipartInput {
input.close();
} else {
for (;;) {
- var av = available();
- if (av == 0) {
- av = makeAvailable();
- if (av == 0) {
+ var avail = available();
+ if (avail == 0) {
+ avail = makeAvailable();
+ if (avail == 0) {
break;
}
}
- skip(av);
+ if (skip(avail) != avail) {
+ // TODO What to do?
+ }
}
}
closed = true;
(commons-fileupload) 01/03: Fix PMD UnnecessaryFullyQualifiedName
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-fileupload.git
commit 5c82e3449e51ab24a41d1df4e6ca1f26c686169a
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Jun 22 17:31:01 2024 -0400
Fix PMD UnnecessaryFullyQualifiedName
---
.../src/main/java/org/apache/commons/fileupload2/core/DiskFileItem.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/DiskFileItem.java b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/DiskFileItem.java
index 74bd5627..bb82efb4 100644
--- a/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/DiskFileItem.java
+++ b/commons-fileupload2-core/src/main/java/org/apache/commons/fileupload2/core/DiskFileItem.java
@@ -386,7 +386,7 @@ public final class DiskFileItem implements FileItem<DiskFileItem> {
*/
@Override
public String getName() {
- return DiskFileItem.checkFileName(fileName);
+ return checkFileName(fileName);
}
/**