[jira] [Commented] (OFBIZ-9523) Improve groovy DSL : runService call makeValidContext

["Jacopo Cappellato (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097980#comment-16097980 ] 

Jacopo Cappellato commented on OFBIZ-9523:
------------------------------------------

Thank you Nicolas, it looks really good to me!
One minor detail: when we call runSync we can probably reuse the local variable "dispatcher" rather then calling again binding.getVariable(...).

> Improve groovy DSL : runService call makeValidContext
> -----------------------------------------------------
>
>                 Key: OFBIZ-9523
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9523
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: framework
>    Affects Versions: Trunk
>         Environment: When you call run service with groovy, you need to be sure that all parametes are good for the service call.
> I propose to simplify this dsl with an automatic parameters check  so you can call directly like that
> {code}
> run service : createProduct, with: context
> {code}
>            Reporter: Nicolas Malin
>            Assignee: Nicolas Malin
>         Attachments: OFBIZ-9523.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)