You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/06/02 03:39:53 UTC
[GitHub] [ozone] ChenSammi opened a new pull request, #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
ChenSammi opened a new pull request, #3474:
URL: https://github.com/apache/ozone/pull/3474
https://issues.apache.org/jira/browse/HDDS-3630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi merged pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
ChenSammi merged PR #3474:
URL: https://github.com/apache/ozone/pull/3474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on a diff in pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
guihecheng commented on code in PR #3474:
URL: https://github.com/apache/ozone/pull/3474#discussion_r887856444
##########
hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html:
##########
@@ -27,7 +27,7 @@ <h2>SCM Information</h2>
</tr>
</tbody>
</table>
-
+callback.sh
Review Comment:
Typo here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sonarcloud[bot] commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144845970
SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=hadoop-ozone&pullRequest=3474)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL)
[![86.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '86.4%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list) [86.4% Coverage](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list)
[![0.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.4%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sonarcloud[bot] commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144724933
SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=hadoop-ozone&pullRequest=3474)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [55 Code Smells](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL)
[![47.2%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/40-16px.png '47.2%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list) [47.2% Coverage](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list)
[![0.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.4%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sonarcloud[bot] commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144475765
SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=hadoop-ozone&pullRequest=3474)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL)
[![85.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '85.9%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list) [85.9% Coverage](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list)
[![0.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.4%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] guihecheng commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
guihecheng commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144887548
LGTM+1
Verified basic functionality manually:
1. deploy an old cluster without this feature
2. write dataset1 with ockg
3. upgrade package with this feature
4. check finalization status
5. verify dataset1 with ockv
6. write dataset2 with ockg
7. check container schemaVersion=v2 by hand
8. do finalizeupgrade
9. check finalization status
10. write dataset3 with ockg
11. check container schemaVersion=v2 by hand
12. restart cluster with the option `hdds.datanode.container.schema.v3.enabled` = true
13. write dataset4 with ockg
14. check container schemaVersion=v3 by hand(here I close the existing OPEN containers by hand)
15. verify previous data with ockv
16. finally do grep `ERROR` logs, nothing found
So I think this merge PR is good from my side, Thanks @ChenSammi ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
ChenSammi commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144754960
There are three issues reported by Sonar. We will leave them be.
1. Medium security issue caused by using "ThreadLocalRandom." Since we leverage the random number to choose which DbVolume to use. It's not security-sensitive code. So we will leave it be.
2. Use try-with-resources or close this "IngestExternalFileOptions" in a "finally" clause. False alert.
3. Use try-with-resources or close this "Options" in a "finally" clause. Actually this Options class doesn't have a close function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] sonarcloud[bot] commented on pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #3474:
URL: https://github.com/apache/ozone/pull/3474#issuecomment-1144405011
SonarCloud Quality Gate failed. [![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')](https://sonarcloud.io/dashboard?id=hadoop-ozone&pullRequest=3474)
[![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG) [2 Bugs](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=BUG)
[![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=VULNERABILITY)
[![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [![E](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/E-16px.png 'E')](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT) [1 Security Hotspot](https://sonarcloud.io/project/security_hotspots?id=hadoop-ozone&pullRequest=3474&resolved=false&types=SECURITY_HOTSPOT)
[![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=hadoop-ozone&pullRequest=3474&resolved=false&types=CODE_SMELL)
[![84.9%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/60-16px.png '84.9%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list) [84.9% Coverage](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_coverage&view=list)
[![0.4%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.4%')](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list) [0.4% Duplication](https://sonarcloud.io/component_measures?id=hadoop-ozone&pullRequest=3474&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] ChenSammi closed pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
Posted by GitBox <gi...@apache.org>.
ChenSammi closed pull request #3474: HDDS-3630: [Merge rocksdb in datanode] merge feature branch to master
URL: https://github.com/apache/ozone/pull/3474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org