You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "tcodehuber (via GitHub)" <gi...@apache.org> on 2024/08/21 09:34:24 UTC

[PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingngFileIO' [amoro]

tcodehuber opened a new pull request, #3124:
URL: https://github.com/apache/amoro/pull/3124

   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
     2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
   -->
   
   ## Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about its use case.
     2. If you fix a bug, you can clarify why it is a bug.
     3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
   -->
   
   Close #2024 .
   
   ## Brief change log
   <!--
   Clearly describe the changes made in modules, classes, methods, etc.
   -->
   
   Tested OK in local env.
   ![image](https://github.com/user-attachments/assets/a862bd8c-3726-47b0-a0c6-3bfffac5a80e)
   
   
   ## How was this patch tested?
   
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] Run test locally before making a pull request
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (yes / no)
   - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3124:
URL: https://github.com/apache/amoro/pull/3124#issuecomment-2323919125

   Thanks for the contribution! @tcodehuber 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong merged PR #3124:
URL: https://github.com/apache/amoro/pull/3124


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on PR #3124:
URL: https://github.com/apache/amoro/pull/3124#issuecomment-2320611951

   @tcodehuber Some conflicts may need to be fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' [amoro]

Posted by "tcodehuber (via GitHub)" <gi...@apache.org>.
tcodehuber commented on PR #3124:
URL: https://github.com/apache/amoro/pull/3124#issuecomment-2323917275

   > @tcodehuber Some conflicts may need to be fixed.
   
   Fixed. @zhoujinsong 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Improvement]: AMS frequently print warning logs of 'Unclosed ResolvingFileIO' [amoro]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3124:
URL: https://github.com/apache/amoro/pull/3124#issuecomment-2301675307

   ## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3124?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   All modified and coverable lines are covered by tests :white_check_mark:
   > Project coverage is 27.18%. Comparing base [(`9def89f`)](https://app.codecov.io/gh/apache/amoro/commit/9def89f0b005d59850bce17b5d255f1bb246d02e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`b9024d9`)](https://app.codecov.io/gh/apache/amoro/commit/b9024d9ed94768856ed2b73f359fed1975029858?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   > Report is 3 commits behind head on master.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #3124      +/-   ##
   ============================================
   - Coverage     27.64%   27.18%   -0.46%     
   + Complexity     2496     2462      -34     
   ============================================
     Files           360      363       +3     
     Lines         37133    37471     +338     
     Branches       5372     5400      +28     
   ============================================
   - Hits          10265    10187      -78     
   - Misses        25908    26327     +419     
   + Partials        960      957       -3     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/amoro/pull/3124/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [trino](https://app.codecov.io/gh/apache/amoro/pull/3124/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `27.18% <ø> (-0.46%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3124?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org