You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/06/30 06:22:15 UTC
[GitHub] [solr] NazerkeBS opened a new pull request #198: SOLR-15124 Remove node/container level admin handlers from ImplicitPl…
NazerkeBS opened a new pull request #198:
URL: https://github.com/apache/solr/pull/198
…ugins.json
https://issues.apache.org/jira/browse/SOLR-XXXXX
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Please provide a short description of the changes you're making with this pull request.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #198:
URL: https://github.com/apache/solr/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r789214825
##########
File path: solr/CHANGES.txt
##########
@@ -503,13 +503,17 @@ Other Changes
* SOLR-14858: Add the server WEB-INF/lib directory to the classpath for the solr-exporter script. Will allow the script
to work when the dist/solrj-lib jars are missing in the Docker image. (Houston Putman)
+* SOLR-15124: Removed three core level admin API endpoints because they are already registered at the node level where they
+ really belong: /admin/threads, /admin/properties, /admin/logging (Nazerke Seidan, David Smiley)
+
Review comment:
indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
madrob commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r665578729
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java
##########
@@ -95,12 +99,23 @@ public void doTestMonitor(final boolean checkBlockedThreadViaPolling) throws Exc
failures.add("never saw lockIsHeldLatch released");
return;
}
- assertQ(req("qt", "/admin/threads", "indent", "true")
- // monitor owner 'ownerT'
- // (which *MAY* also be waiting on doneWithTestLatch, but may not have reached that line yet)
- , "//lst[@name='thread'][str[@name='name'][.='test-thread-monitor-owner']]"
- + " [arr[@name='monitors-locked']/str[contains(.,'TestMonitorStruct')]]"
- );
+
+ @SuppressWarnings({"unchecked"})
+ NamedList<Object> threads = (NamedList<Object>) readProperties()._get("system/threadDump", null);
+ boolean found = false;
+ for (Map.Entry<String, Object> threadEntry : threads) {
+ @SuppressWarnings({"unchecked"})
+ NamedList<Object> thread = (NamedList<Object>) threadEntry.getValue();
+ // monitor owner 'ownerT'
+ // (which *MAY* also be waiting on doneWithTestLatch, but may not have reached that line yet)
+ if (thread._getStr("name", null).contains("test-thread-monitor-owner")) {
+ if (thread._get("monitors-locked", "").toString().contains("TestMonitorStruct")) {
+ found = true;
+ break;
+ }
+ }
+ }
+ assertTrue(found);
Review comment:
Please add a failure message to this assertion.
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/ThreadDumpHandlerTest.java
##########
@@ -214,16 +261,36 @@ public void doTestOwnableSync(final boolean checkWaitingThreadViaPolling) throws
Thread.sleep(10); // 10ms at a time, at most 5 sec total
}
if (lock.hasQueuedThread(blockedT)) {
- assertQ(req("qt", "/admin/threads", "indent", "true")
- // same lock owner 'ownerT'
- , "//lst[@name='thread'][str[@name='name'][.='test-thread-sync-lock-owner']]"
- + " [arr[@name='synchronizers-locked']/str[contains(.,'ReentrantLock')]]"
- // blocked thread 'blockedT', waiting on the lock
- , "//lst[@name='thread'][str[@name='name'][.='test-thread-sync-lock-blocked']]"
- + " [str[@name='state'][.='WAITING']]"
- + " [lst[@name='lock-waiting'][lst[@name='owner']/str[.='test-thread-sync-lock-owner']]]"
- );
-
+ @SuppressWarnings({"unchecked"})
+ NamedList<Object> blockedThreads = (NamedList<Object>) readProperties()._get("system/threadDump", null);
+ found = false;
+ for (Map.Entry<String, Object> threadEntry : blockedThreads) {
+ @SuppressWarnings({"unchecked"})
+ NamedList<Object> thread = (NamedList<Object>) threadEntry.getValue();
+ // lock owner 'ownerT'
+ if (thread._getStr("name", null).contains("test-thread-sync-lock-owner")) {
+ if (thread._get("synchronizers-locked", "").toString().contains("ReentrantLock")) {
+ found = true;
+ break;
+ }
+ }
+ }
Review comment:
Can this logic be refactored into a helper method? It looks like it's been repeated several times already, looking for a thread with a given name and some other condition that could be expressed via a Predicate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r663216784
##########
File path: solr/core/src/resources/ImplicitPlugins.json
##########
@@ -77,18 +77,6 @@
"/admin/plugins": {
"class": "solr.PluginInfoHandler"
},
- "/admin/threads": {
- "class": "solr.ThreadDumpHandler",
- "useParams":"_ADMIN_THREADS"
- },
- "/admin/properties": {
- "class": "solr.PropertiesRequestHandler",
- "useParams":"_ADMIN_PROPERTIES"
- },
- "/admin/logging": {
- "class": "solr.LoggingHandler",
- "useParams":"_ADMIN_LOGGING"
- },
Review comment:
Please also update implicit-requesthandlers.adoc to match.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r789214464
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
##########
@@ -66,27 +70,19 @@ public void testLogLevelHandlerOutput() throws Exception {
config.getLoggerConfig(PARENT_LOGGER_NAME));
assertEquals(Level.DEBUG, config.getLoggerConfig(CLASS_LOGGER_NAME).getLevel());
- assertQ("Show Log Levels OK",
- req(CommonParams.QT,"/admin/logging")
- ,"//arr[@name='loggers']/lst/str[.='"+CLASS_LOGGER_NAME+"']/../str[@name='level'][.='DEBUG']"
- ,"//arr[@name='loggers']/lst/str[.='"+PARENT_LOGGER_NAME+"']/../null[@name='level']"
- );
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
+ ModifiableSolrParams mparams = new ModifiableSolrParams();
+ mparams.set("set", PARENT_LOGGER_NAME + ":TRACE");
+ client.request(new GenericSolrRequest(SolrRequest.METHOD.GET, "/admin/info/logging", mparams));
- assertQ("Set a (new) level",
Review comment:
AFAICT, the purpose of these assertions is to assert the response of getting the log levels from Solr. Your changes removed that; thus it's untested (right?). It should be tested to protect against regressions in the format or what levels are included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r788996740
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
##########
@@ -66,27 +70,19 @@ public void testLogLevelHandlerOutput() throws Exception {
config.getLoggerConfig(PARENT_LOGGER_NAME));
assertEquals(Level.DEBUG, config.getLoggerConfig(CLASS_LOGGER_NAME).getLevel());
- assertQ("Show Log Levels OK",
- req(CommonParams.QT,"/admin/logging")
- ,"//arr[@name='loggers']/lst/str[.='"+CLASS_LOGGER_NAME+"']/../str[@name='level'][.='DEBUG']"
- ,"//arr[@name='loggers']/lst/str[.='"+PARENT_LOGGER_NAME+"']/../null[@name='level']"
- );
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
+ ModifiableSolrParams mparams = new ModifiableSolrParams();
+ mparams.set("set", PARENT_LOGGER_NAME + ":TRACE");
+ client.request(new GenericSolrRequest(SolrRequest.METHOD.GET, "/admin/info/logging", mparams));
- assertQ("Set a (new) level",
Review comment:
@dsmiley not sure if we still need to test "Set a (new) level" or "Show Log Levels OK" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r787072050
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -61,9 +64,11 @@ public void testDisabledRedaction() throws Exception {
@SuppressWarnings({"unchecked"})
private NamedList<Object> readProperties() throws Exception {
- SolrQueryResponse rsp = new SolrQueryResponse();
- SolrQueryRequest req = req();
- h.getCoreContainer().getInfoHandler().getPropertiesHandler().handleRequestBody(req, rsp);
- return (NamedList<Object>) rsp.getValues().get("system.properties");
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
Review comment:
Great!
And can you also use this approach for the other tests you added? At least I think you added some that could use this technique; I'm not sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r692331051
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -62,13 +61,9 @@ public void testDisabledRedaction() throws Exception {
@SuppressWarnings({"unchecked"})
private NamedList<Object> readProperties() throws Exception {
- String xml = h.query(req(
- CommonParams.QT, "/admin/properties",
- CommonParams.WT, "xml"
- ));
-
- XMLResponseParser parser = new XMLResponseParser();
- return (NamedList<Object>)
- parser.processResponse(new StringReader(xml)).get("system.properties");
+ SolrQueryResponse rsp = new SolrQueryResponse();
+ SolrQueryRequest req = req();
+ new PropertiesRequestHandler().handleRequestBody(req, rsp);
Review comment:
If we wanted to test the properties handler within the core container then
```suggestion
h.getCoreContainer().getInfoHandler().getPropertiesHandler().handleRequestBody(req, rsp);
```
could be an alternative here.
The `qt=/admin/properties` previously would indirectly also test accessibility via that path, though I'm not sure how much that is a key part of the test? Or if there is a replacement -- `/admin/info/properties` (?) -- and/or how feasible using that in the test would be ...
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r788997750
##########
File path: solr/CHANGES.txt
##########
@@ -503,13 +503,17 @@ Other Changes
* SOLR-14858: Add the server WEB-INF/lib directory to the classpath for the solr-exporter script. Will allow the script
to work when the dist/solrj-lib jars are missing in the Docker image. (Houston Putman)
+* SOLR-15124: Removed three core level admin API endpoints because they are already registered at the node level where they
+ really belong: /admin/threads, /admin/properties, /admin/logging (Nazerke Seidan, David Smiley)
+
Review comment:
@dsmiley should I include this change content in `major-changes-in-solr-9.adoc `?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r663216784
##########
File path: solr/core/src/resources/ImplicitPlugins.json
##########
@@ -77,18 +77,6 @@
"/admin/plugins": {
"class": "solr.PluginInfoHandler"
},
- "/admin/threads": {
- "class": "solr.ThreadDumpHandler",
- "useParams":"_ADMIN_THREADS"
- },
- "/admin/properties": {
- "class": "solr.PropertiesRequestHandler",
- "useParams":"_ADMIN_PROPERTIES"
- },
- "/admin/logging": {
- "class": "solr.LoggingHandler",
- "useParams":"_ADMIN_LOGGING"
- },
Review comment:
Please also update implicit-requesthandlers.adoc to match.
edit: never mind, please ignore, sorry, just saw the https://issues.apache.org/jira/browse/SOLR-15124?focusedCommentId=17277347&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17277347 onwards discussion re: this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r784824339
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -62,13 +61,9 @@ public void testDisabledRedaction() throws Exception {
@SuppressWarnings({"unchecked"})
private NamedList<Object> readProperties() throws Exception {
- String xml = h.query(req(
- CommonParams.QT, "/admin/properties",
- CommonParams.WT, "xml"
- ));
-
- XMLResponseParser parser = new XMLResponseParser();
- return (NamedList<Object>)
- parser.processResponse(new StringReader(xml)).get("system.properties");
+ SolrQueryResponse rsp = new SolrQueryResponse();
+ SolrQueryRequest req = req();
+ new PropertiesRequestHandler().handleRequestBody(req, rsp);
Review comment:
I had a look if there is a replacement for `qt=/admin/properties` to check the path accessibility, but couldn't find one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] NazerkeBS commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
NazerkeBS commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r788998344
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/LoggingHandlerTest.java
##########
@@ -66,27 +70,19 @@ public void testLogLevelHandlerOutput() throws Exception {
config.getLoggerConfig(PARENT_LOGGER_NAME));
assertEquals(Level.DEBUG, config.getLoggerConfig(CLASS_LOGGER_NAME).getLevel());
- assertQ("Show Log Levels OK",
- req(CommonParams.QT,"/admin/logging")
- ,"//arr[@name='loggers']/lst/str[.='"+CLASS_LOGGER_NAME+"']/../str[@name='level'][.='DEBUG']"
- ,"//arr[@name='loggers']/lst/str[.='"+PARENT_LOGGER_NAME+"']/../null[@name='level']"
- );
+ SolrClient client = new EmbeddedSolrServer(h.getCore());
+ ModifiableSolrParams mparams = new ModifiableSolrParams();
+ mparams.set("set", PARENT_LOGGER_NAME + ":TRACE");
+ client.request(new GenericSolrRequest(SolrRequest.METHOD.GET, "/admin/info/logging", mparams));
- assertQ("Set a (new) level",
Review comment:
btw I run all tests and all they pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #198:
URL: https://github.com/apache/solr/pull/198#issuecomment-1017601194
Looks like you didn't run all tests since this fails consistently:
```
gradlew :solr:core:test --tests "org.apache.solr.handler.admin.LoggingHandlerTest.testLogLevelHandlerOutput" -Ptests.jvms=8 -Ptests.jvmargs=-XX:TieredStopAtLevel=1 -Ptests.seed=8779CE617BA89580 -Ptests.file.encoding=ISO-8859-1
```
Also, I keep forgetting this, but we have a `major-changes-in-solr-9.adoc` which should have noticeable changes like this (even though not "major").
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] cpoerschke commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
cpoerschke commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r663209951
##########
File path: solr/core/src/java/org/apache/solr/handler/admin/LoggingHandler.java
##########
@@ -47,23 +47,16 @@
public class LoggingHandler extends RequestHandlerBase implements SolrCoreAware {
Review comment:
```suggestion
public class LoggingHandler extends RequestHandlerBase {
```
maybe since `inform(SolrCore core)` is becoming a no-op or comment w.r.t. why `inform` is needed albeit as a no-op.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley commented on a change in pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley commented on a change in pull request #198:
URL: https://github.com/apache/solr/pull/198#discussion_r784958135
##########
File path: solr/core/src/test/org/apache/solr/handler/admin/PropertiesRequestHandlerTest.java
##########
@@ -62,13 +61,9 @@ public void testDisabledRedaction() throws Exception {
@SuppressWarnings({"unchecked"})
private NamedList<Object> readProperties() throws Exception {
- String xml = h.query(req(
- CommonParams.QT, "/admin/properties",
- CommonParams.WT, "xml"
- ));
-
- XMLResponseParser parser = new XMLResponseParser();
- return (NamedList<Object>)
- parser.processResponse(new StringReader(xml)).get("system.properties");
+ SolrQueryResponse rsp = new SolrQueryResponse();
+ SolrQueryRequest req = req();
+ new PropertiesRequestHandler().handleRequestBody(req, rsp);
Review comment:
Please use `new EmbeddedSolrServer(h.getCore());` to give you a client to make a normal request into Solr. Ideally our test infrastructure would make this trick/technique more obvious / transparent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] dsmiley merged pull request #198: SOLR-15124 Remove container level admin handlers from ImplicitPlugins.json
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #198:
URL: https://github.com/apache/solr/pull/198
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org