You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/29 14:00:58 UTC

[GitHub] [incubator-nuttx] v01d opened a new pull request #2440: nrf52 ADC: minor fixes

v01d opened a new pull request #2440:
URL: https://github.com/apache/incubator-nuttx/pull/2440


   ## Summary
   
   This introduces various minor fixes to ADC module:
   * Ensure CALDONE event is set to zero before initiating calibration (avoid misdetection of calibration complete)
   * Configuration of N channel was done using P channel configuration
   * Calibration is now done after configuration
   * Peripheral is now disabled during configuration
   
   The last point is important and I think other peripherals may have the same issue. nRF52 shares register space between certain peripherals (which can obviously not be used simultaneously) and thus it is required that a peripheral is first configured and then enabled.
   
   ## Impact
   
   ADC
   
   ## Testing
   
   Using ADC and works correctly.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] acassis merged pull request #2440: nrf52 ADC: minor fixes

Posted by GitBox <gi...@apache.org>.
acassis merged pull request #2440:
URL: https://github.com/apache/incubator-nuttx/pull/2440


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org