[GitHub] [incubator-pinot] Jackie-Jiang commented on pull request #5400: Do not release the PinotDataBuffer when closing the index

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on pull request #5400:
URL: https://github.com/apache/incubator-pinot/pull/5400#issuecomment-630540590


   > I guess the claim is that memory manager needs to be closed at the close of a segment. It will be good to put that comment in the memory manager interface. If for any reason the memory manager is retained across interfaces, a lot of memory will not be released.
   
   Both segment directory and memory manager are closed when destroying the segment, which is the expected behavior. They are responsible of allocating and releasing the buffers, and might reuse the buffer across different calls.
   
   > The 'reused later' comment needs some explanation. What may be the re-use of those buffers?
   
   In SegmentDirectory, we cache the buffer for each index and return the same buffer if the same buffer is requested twice.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org