[GitHub] [incubator-apisix] totemofwolf opened a new issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key

[GitBox <gi...@apache.org>]

totemofwolf opened a new issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key
URL: https://github.com/apache/incubator-apisix/issues/1161
 
 
   ### Issue description
   
   I used to use this to deal with ratelimit case (for example: ratelimit for sms verifycode):
   
   `mobile` is users' mobile phone no from http post body. But for other people maybe use `mobile_phone` instead or key like `cookie` from request header.
   
   So how can we avoid hard coding this `key` in the lua code?
   
   ``` lua
   location /verifycode {
       default_type 'application/json';
   
       #so you can to use set_by_lua from $mobile
       set $mobile '';
   
       access_by_lua_block {
           local request_method = ngx.var.request_method
           local args = nil
           if "GET" == request_method then
               local arg = ngx.req.get_uri_args()["mobile"] or 0
               ngx.var.mobile = arg
           elseif "POST" == request_method then
               cjson = require "cjson"
               local body = ngx.req.get_body_data()
               if body then
                   -- parsing json body for  {mobile : 123, address: .... }
                   local body = cjson.decode(body)
                   local arg = body.mobile or 0
                   ngx.var.mobile = arg
               end
           end
   
           local ratelimit = require "resty.redis.ratelimit"
           local lim, err = ratelimit.new("verifycode", "1r/m", 0, 0)
   
           if not lim then
               ngx.log(ngx.ERR,
                       "failed to instantiate a resty.redis.ratelimit object: ", err)
               return ngx.exit(500)
           end
   
           local red = { host = "", port = 6379, timeout = 1, pass = "" }
   
           local key = ngx.var.mobile
           local delay, err = lim:incoming(key, red)
           if not delay then
               if err == "rejected" then
                   return ngx.exit(429)
                   -- cjson = require "cjson"
                   -- ngx.say(cjson.encode({ code=1603, message = "Too Many Requests", successful = true }))
               end
               ngx.log(ngx.ERR, "failed to limit req: ", err)
               return ngx.exit(500)
           end
   
           if delay >= 0.001 then
               -- the 2nd return value holds the number of excess requests
               -- per second for the specified key.
               local excess = err
   
               ngx.sleep(delay)
           end
       }
   }
   
   ```
   
   ### Environment
   
   * apisix version (cmd: `apisix version`): 1.0
   * OS: alpine 3.7
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming closed issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key

[GitBox <gi...@apache.org>]

moonming closed issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key
URL: https://github.com/apache/incubator-apisix/issues/1161
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-apisix] moonming commented on issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key

[GitBox <gi...@apache.org>]

moonming commented on issue #1161: request help: How to deal with `user specific key` from post body as a ratelimit or limit-count key
URL: https://github.com/apache/incubator-apisix/issues/1161#issuecomment-591186006
 
 
   please refer to https://lists.apache.org/thread.html/r9175ca0aacbbf81e7296f25243d3fde0e9b0c8ece590b5c5f33d90c2%40%3Cdev.apisix.apache.org%3E

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services