You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "acassis (via GitHub)" <gi...@apache.org> on 2023/10/22 20:41:06 UTC
[PR] Rename Shift game to Brickmatch and add an board example to esp32-devkitc [nuttx]
acassis opened a new pull request, #10996:
URL: https://github.com/apache/nuttx/pull/10996
## Summary
Rename Shift game to Brickmatch and add an board example to esp32-devkitc
## Impact
Users will be able to test it on ESP32
## Testing
esp32-devkitc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename Shift game to Brickmatch and add an board example to esp32-devkitc [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #10996:
URL: https://github.com/apache/nuttx/pull/10996#issuecomment-1775329522
@acassis please update `Documentation/applications/games/index.rst` too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename Shift game to Brickmatch and add an board example to esp32-devkitc [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10996:
URL: https://github.com/apache/nuttx/pull/10996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename Shift game to Brickmatch and add an board example to esp32-devkitc [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10996:
URL: https://github.com/apache/nuttx/pull/10996#issuecomment-1775292039
@xiaoxiang781216 could you please help me to decrypt the CI error message? :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Rename Shift game to Brickmatch and add an board example to esp32-devkitc [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #10996:
URL: https://github.com/apache/nuttx/pull/10996#issuecomment-1776665552
@acassis hi Alana, this PR introduces new warnings to the doc build:
> /home/raiden00/git/RTOS/nuttx/nuttx/Documentation/applications/games/index.rst:14: WARNING: toctree contains reference to nonexisting document 'applications/games/brichmatch'
> checking consistency... /home/raiden00/git/RTOS/nuttx/nuttx/Documentation/applications/games/brickmatch.rst: WARNING: document isn't included in any toctree
it looks like our CI doesn't detect documentation warnings well (or does it detect them at all?).
One of the reasons why I place each app doc in a new folder (`appname/index.rst`) is to prevent such errors. Consistency helps avoid mistakes :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org