You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/25 07:25:43 UTC
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich opened a new pull request, #44: Add Scala 3 support
mdedetrich opened a new pull request, #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44
TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on a diff in pull request #44: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257954228
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
one solution would be to use Slack 3.3.3 for Scala 2 and 3.5.0-M4 for Scala 3 - that way Scala 2 users won't have t use a pre-release milestone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [pekko-persistence-jdbc]
Posted by "Lukah0173 (via GitHub)" <gi...@apache.org>.
Lukah0173 commented on PR #44:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/44#issuecomment-2031764395
Greatly looking forward to the release / milestone for Scala 3 support :+1:
May I ask if there is an ETA for this? I see there's snapshots but if there's a release nearby I'll wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516083032
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,23 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.12"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.3"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = PekkoCoreDependency.version
+ val PekkoBinaryVersion = PekkoVersion.take(3)
- val SlickVersion = "3.3.3"
+ val LogbackForSlf4j1Version = "1.2.13"
+ val LogbackForSlf4j2Version = "1.3.14"
+ val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
Review Comment:
in pekko-persistence-jdbc 1.1, I think we should just use the LogbackForSlf4j2Version regardless of Pekko version
Slick 3.5.0 is slf4j based anyway
Code built with slif4j v1 works with slf4j v2 at runtime but this is not necessarily true the other way around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257967998
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/JournalSequenceActor.scala:
##########
@@ -48,15 +48,15 @@ object JournalSequenceActor {
* Efficient representation of missing elements using NumericRanges.
* It can be seen as a collection of OrderingIds
*/
- private case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
+ final case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
Review Comment:
This is due to
```
[error] -- Error: /Users/mdedetrich/github/incubator-pekko-persistence-jdbc/core/src/main/scala/org/apache/pekko/persistence/jdbc/query/JournalSequenceActor.scala:97:6
[error] 97 | def receive(
[error] | ^
[error] |non-private method receive in class JournalSequenceActor refers to private class MissingElements
[error] |in its type signature (
[error] | currentMaxOrdering:
[error] | org.apache.pekko.persistence.jdbc.query.JournalSequenceActor.OrderingId,
[error] | missingByCounter:
[error] | Map[Int,
[error] | org.apache.pekko.persistence.jdbc.query.JournalSequenceActor.
[error] | MissingElements
[error] | ]
[error] | ,
[error] |moduloCounter: Int, previousDelay: concurrent.duration.FiniteDuration):
[error] | JournalSequenceActor.this.Receive
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1258227577
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/query/JournalSequenceActor.scala:
##########
@@ -48,15 +48,15 @@ object JournalSequenceActor {
* Efficient representation of missing elements using NumericRanges.
* It can be seen as a collection of OrderingIds
*/
- private case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
+ final case class MissingElements(elements: Seq[NumericRange[OrderingId]]) {
Review Comment:
Resolved in https://github.com/apache/incubator-pekko-persistence-jdbc/pull/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1868142880
PR was just rebased against main (which now has #94 ) merged so the only thing that this PR now contains is the Scala 3/Slick version changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1498726459
##########
.github/workflows/h2-test.yml:
##########
@@ -19,9 +19,11 @@ jobs:
matrix:
include:
- { java-version: 8, scala-version: 2.12, sbt-opts: '' }
- - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 3.3, sbt-opts: '' }
- { java-version: 11, scala-version: 2.12, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
- - { java-version: 11, scala-version: 2.13, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
+ - { java-version: 11, scala-version: 2.13, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
+ - { java-version: 11, scala-version: 3.3, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
Review Comment:
Jvmcicompiler is removed in later version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516098061
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,23 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.12"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.3"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = PekkoCoreDependency.version
+ val PekkoBinaryVersion = PekkoVersion.take(3)
- val SlickVersion = "3.3.3"
+ val LogbackForSlf4j1Version = "1.2.13"
+ val LogbackForSlf4j2Version = "1.3.14"
+ val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
Review Comment:
I have https://github.com/apache/incubator-pekko-connectors/pull/539 but still need to investigate why kudu and solr present issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301325101
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:
##########
@@ -47,7 +47,6 @@ object JdbcDurableStateStore {
/**
* API may change
*/
-@ApiMayChange
Review Comment:
The project will not compile on Scala 3 because of this annotation, need to report bug upstream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1860568311
Slick-pg has just released a Scala 3 artifact for the latest slick milestone. I just want to leave a bit of time for people to try it, then I would do the release with G-d's help.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1865930468
@mdedetrich could you also update this PR to use Slick 3.3.0-M5 and Scala 3.3.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1498727929
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.12"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.1"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = PekkoCoreDependency.version
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-RC1"
Review Comment:
Should we only use this version in scala 3 build？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516070913
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Oh I see what you mean, `slick.backwards.excludes` [already exists ](https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes).
This is however an oversight because if you read the currently existing `slick.backwards.excludes` you can see that its referring the Scala 3 update which the previous version of pekko-persistence-jdbc 1.0.x never had so I think it was somehow accidentally committed when it shouldn't have been, see this commit https://github.com/apache/incubator-pekko-persistence-jdbc/commit/86923ecff2543ea3e31cd8b794fb184bb3957bef (you wanted me to merge a preparation Scala 3 [PR](https://github.com/apache/incubator-pekko-persistence-jdbc/pull/94))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516055483
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
are we sure all these still apply?
would it be possible to put the slick upgrade issues in a separate excludes file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "nvollmar (via GitHub)" <gi...@apache.org>.
nvollmar commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1860076204
@mdedetrich what is the state of this? Slick is still in M5 but it would be good to have a Scala 3 artifact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1498737800
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.12"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.1"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = PekkoCoreDependency.version
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-RC1"
Review Comment:
See discussion at https://github.com/slick/slick/discussions/2891#discussioncomment-8550269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/44#issuecomment-2032030969
@Lukah0173 there is a comment right above the one that you just made that answers your question.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-2003245234
we are planning to create a milestone release candidate in the next week or so
In ASF, releases are discussed on our mailing lists. This discussion is at https://lists.apache.org/thread/95sjkpbdomwbbhvw1os9g0ol2f6rt32b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "fabienfoerster (via GitHub)" <gi...@apache.org>.
fabienfoerster commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-2003233800
Hi,
Do we know when a version with the Scala 3 support will be released ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1498738086
##########
.github/workflows/h2-test.yml:
##########
@@ -19,9 +19,11 @@ jobs:
matrix:
include:
- { java-version: 8, scala-version: 2.12, sbt-opts: '' }
- - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 2.13, sbt-opts: '' }
+ - { java-version: 8, scala-version: 3.3, sbt-opts: '' }
- { java-version: 11, scala-version: 2.12, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
- - { java-version: 11, scala-version: 2.13, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
+ - { java-version: 11, scala-version: 2.13, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
+ - { java-version: 11, scala-version: 3.3, sbt-opts: '-J-XX:+UnlockExperimentalVMOptions -J-XX:+UseJVMCICompiler' }
Review Comment:
Thanks, I actually want to remove all of these experimental options but I will do it in a later PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516094490
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,23 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.12"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.3"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = PekkoCoreDependency.version
+ val PekkoBinaryVersion = PekkoVersion.take(3)
- val SlickVersion = "3.3.3"
+ val LogbackForSlf4j1Version = "1.2.13"
+ val LogbackForSlf4j2Version = "1.3.14"
+ val LogbackVersion = if (PekkoBinaryVersion == "1.0") LogbackForSlf4j1Version else LogbackForSlf4j2Version
Review Comment:
Sure, I just copied this from pekko-connectors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516059842
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
> would it be possible to put the slick upgrade issues in a separate excludes file?
What do you mean by this, its all related? The update from Slick 3.3.x to 3.3.5 is completely binary breaking so all of the excludes are due to the slick upgrade, I don't know how you would split them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516057094
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Let me check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516080522
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -1,7 +1,42 @@
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
can you add a license header like https://github.com/apache/incubator-pekko-connectors/pull/223/files#diff-f40f47eb001aeab00857490311b5a573779b3088aaa6ebc0b7a3dc80fd900d89 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/44#issuecomment-2032087441
> Thanks @pjfanning - I've been following this and the mailing list. I was just checking if there's any updates or change in status / plans. If there's any chance for a target day to release I can plan the timing on our end too 🙏
Instead of continuously asking 'are we there yet?' - there are other options like engaging with the blocking issue or build the jars yourself if you absolutely must have the jars today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1687926096
> That's a big step forward. Unfortunately, there doesn't seem to be any rush on getting Slick 3.5.0 released.
Slick is waiting for the Scala 3.3.1 release in order to compile Slick for Scala 3 (there is a bug in Scala 3.3.0 that means it doesn't work in Slick).
So its not that Slick 3.5.0 is just sitting there, its blocked by upstream Scala. Considering that 3.3.1-RC5 is has been out for a couple of weeks already I think that a Scala 3.5.1 release is on the horizon soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on pull request #44: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1687922580
> So I managed to complete the PR and fix all of the remaining issues, the only thing we are waiting on for now is a full release of Slick 3.5.0 which contains Scala 3 support.
That's a big step forward. Unfortunately, there doesn't seem to be any rush on getting Slick 3.5.0 released.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1687918991
So I managed to complete the PR and fix all of the remaining issues, the only thing we are waiting on for now is a full release of Slick 3.5.0 which contains Scala 3 support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on pull request #44: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1687964866
> > That's a big step forward. Unfortunately, there doesn't seem to be any rush on getting Slick 3.5.0 released.
>
> Slick is waiting for the Scala 3.3.1 release in order to compile Slick for Scala 3 (there is a bug in Scala 3.3.0 that means it doesn't work in Slick).
>
> So its not that Slick 3.5.0 is just sitting there, its blocked by upstream Scala. Considering that 3.3.1-RC5 has been [out for a few of weeks already](https://contributors.scala-lang.org/t/3-3-1-release-thread/6208/7?u=mdedetrich) I think that a Scala 3.5.1 release is on the horizon soon.
Scala 3.3.1 is getting some reverts so I think a RC6 is pretty likely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1865912908
I think the only failures were here, can you retest with it?
On Wed, Dec 20, 2023, 11:09 PM Matthew de Detrich ***@***.***>
wrote:
> @nafg <https://github.com/nafg> Not sure if relevant but Scala 3.3.2-RC1
> just came out which may have fixed some relevant issues that effect Slick
>
> —
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1865448086>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAAYAUEBUP6T4TCZ334W6HDYKOY5ZAVCNFSM6AAAAAAYONKS2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRVGQ2DQMBYGY>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1865921705
@mdedetrich could you consider taking out the 'chore' changes and doing them in a separate PR that we can merge first?
By chore, I mean the adding of type declarations to implicit vals and things of that nature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516067662
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
@pjfanning In any case I have re-regenerated the `core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes` file to only contain the bare necessary slick excludes that MiMa complains about
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257993454
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
This has already been resolved in latest PR, we will release when 3.5.0 is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1258040292
##########
.github/workflows/checks.yml:
##########
@@ -66,7 +66,7 @@ jobs:
- name: Compile all code with fatal warnings for Java 11, Scala 2.12 and Scala 2.13
# Run locally with: sbt 'clean ; +Test/compile ; +It/compile'
- run: sbt "; Test/compile; It/compile"
Review Comment:
This wasn't even properly cross compiling, i.e. it was only compiling for the default Scala version and not all of `CrossScalaVersions`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301348004
##########
core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:
##########
@@ -47,7 +47,6 @@ object JdbcDurableStateStore {
/**
* API may change
*/
-@ApiMayChange
Review Comment:
Upstream bug created at https://github.com/lampepfl/dotty/issues/18441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1866913591
I also added the MiMa filters from the other PR (i.e. https://github.com/apache/incubator-pekko-persistence-jdbc/blob/6f4c970d2980cbbf7ee8c63db2d4b831f9300653/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes) to see if this PR builds properly, in any case this will get rebased out when the other PR lands.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1958813880
Please don't merge this PR until we make a discussion about whether its appropriate for us as a snapshot
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1983339812
@mdedetrich looks like Slick 3.5.0 uses slf4j v2 - so we should probably upgrade logback to 1.3.14 (latest jdk8 supporting logback that targets slf4j v2)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516070913
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Oh I see what you mean, `slick.backwards.excludes` [already exists ](https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes).
This is however an oversight because if you read the currently existing `slick.backwards.excludes` you can see that its referring the Scala 3 update which the previous version of pekko-persistence-jdbc 1.0.x never had so I think it was somehow accidentally committed when it shouldn't have been.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1860092518
I think it would be best to ask Slick to release 3.5.0 first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1865448086
@nafg Not sure if relevant but Scala 3.3.2-RC1 just came out which may have fixed some relevant issues that effect Slick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1935076874
Update to Slick 3.5.0-RC1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1983342982
> @mdedetrich looks like Slick 3.5.0 uses slf4j v2 - so we should probably upgrade logback to 1.3.14 (latest jdk8 supporting logback that targets slf4j v2)
Got it, I'll look into it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516070913
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Oh I see what you mean, `slick.backwards.excludes` [already exists ](https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes).
This is however an oversight because if you read the currently existing `slick.backwards.excludes` you can see that its referring the Scala 3 update which the previous version of pekko-persistence-jdbc 1.0.x never had so I think it was somehow accidentally committed when it shouldn't have been, see this commit https://github.com/apache/incubator-pekko-persistence-jdbc/commit/86923ecff2543ea3e31cd8b794fb184bb3957bef (you wanted me to merge a preparation Scala 3 PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1983447898
@pjfanning PR is now ready
I noticed that https://github.com/apache/incubator-pekko-persistence-jdbc/blob/main/core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes is missing a header and its in the wrong location (it should be in the `1.0.x` folder and not `1.1.x`) but I will change this in a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] nafg commented on a diff in pull request #44: Add Scala 3 support
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1257991852
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
> one solution would be to use Slack 3.3.3 for Scala 2 and 3.5.0-M4 for Scala 3 - that way Scala 2 users won't have t use a pre-release milestone
There's 3.4.1. But I don't recommend having different versions. How soon do you need to release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on a diff in pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301435870
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
I would also advocate waiting for a Slick 3.5.0 release. I wouldn't be against merging this PR in order to create snapshots for Scala 3 if we make a future agreement that the first release of pekko-persistence-jdbc will contain Slick 3.5.0, otherwise we would have to revert this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] MrMaxxan commented on a diff in pull request #44: Add Scala 3 support
Posted by "MrMaxxan (via GitHub)" <gi...@apache.org>.
MrMaxxan commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301182553
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
Just checking: is it the merge of this PR that you will wait for until slick 3.5.0 is released or is it the release of the pekko-persistence-jdbc library that will wait for this? (I just wonder since I'm in a project where we are hoping for a stable release of pekko-persistence-jdbc for Scala 2 soon. 😁)
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
Just checking: is it the merge of this PR that you will wait for until slick 3.5.0 is released or is it the release of the pekko-persistence-jdbc library that will wait for this? (I just wonder since I'm in a project where we are hoping for a stable release of pekko-persistence-jdbc for Scala 2 soon. 😁)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] pjfanning commented on a diff in pull request #44: Add Scala 3 support
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1301244343
##########
project/Dependencies.scala:
##########
@@ -8,16 +8,18 @@
*/
import sbt._
+import Keys._
object Dependencies {
// Keep in sync with .github CI build
val Scala212 = "2.12.18"
val Scala213 = "2.13.11"
- val ScalaVersions = Seq(Scala212, Scala213)
+ val Scala3 = "3.3.0"
+ val ScalaVersions = Seq(Scala212, Scala213, Scala3)
val PekkoVersion = "1.0.0-RC3"
- val SlickVersion = "3.3.3"
+ val SlickVersion = "3.5.0-M4"
Review Comment:
@MrMaxxan one option would be for you to clone the existing main branch and use that code in your project directly or to create a jar. You could try a snapshot jar first to see if it works for you.
The priority of Pekko releases is discussed on the dev@pekko.apache.org list and noone has yet asked for this module to be released. Have a look through the emails at https://lists.apache.org/list.html?dev@pekko.apache.org
Apache release process requires that a fair number of people review the releases and there are quite a few Pekko repos to release so basically:
* Pekko Connectors has more people looking for it to be released but there are one or two changes still being looked at
* Other than Slick 3.5 / Scala 3 support, the only thing blocking a pekko-persistence-jdbc release is setting up the release notes and related doc tasks
* I'd prefer to wait for Slick 3.5 / Scala 3 support than to release what we have as 1.0.0 to cut down on release overhead
* if there was evidence that Slick 3.5.0 is a ways off yet and that there were a number of users waiting on this release, then that might change my mind
* Noone is pressing for any other module releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1866172030
> When I said 'chore', I was implying just the 1.0.x friendly changes as opposed to the bin compatibility breaking changes - not a big deal though.
Yeah I wasn't aware there was bincompat breaking changes because when the PR was originally made the MiMa check wasn't even enabled yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1958780302
So it is being [asked](https://github.com/slick/slick/discussions/2891#discussioncomment-8550269) if we can publish these changes so that people can test Slick 3.5.0-RC1 before Slick does a full release. Since 1.0.x branch is already setup if we want to do snapshots we can just merge this PR as is, milestone would obviously require a proper vote which I am not against but may be a bit redundant if stakeholders have no issue in testing with snapshot.
@pjfanning wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-2003241242
I'm not sure if we have a release planned yet, but it would be valuable if you could test the snapshots from https://repository.apache.org/content/groups/snapshots/org/apache/pekko/pekko-persistence-jdbc_3/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [pekko-persistence-jdbc]
Posted by "Lukah0173 (via GitHub)" <gi...@apache.org>.
Lukah0173 commented on PR #44:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/44#issuecomment-2032075913
Thanks @pjfanning - I've been following this and the mailing list. I was just checking if there's any updates or change in status / plans. If there's any chance for a target day to release I can plan the timing on our end too :pray:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [pekko-persistence-jdbc]
Posted by "Lukah0173 (via GitHub)" <gi...@apache.org>.
Lukah0173 commented on PR #44:
URL: https://github.com/apache/pekko-persistence-jdbc/pull/44#issuecomment-2032170291
Thanks for updating the mailing list, I wasn't aware of the blocking issue. I'll follow the activity there. I'm not so familiar with the ASF release process so I'm unsure of the best way to get a view of release plans / blocks / ways to help, but I'll try to do some research too. Thanks :+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] nafg commented on pull request #44: Add Scala 3 support
Posted by "nafg (via GitHub)" <gi...@apache.org>.
nafg commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1628330119
Slick 3.5.0-M4 is out for Scala 3 (and 2.12 and 2.13)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-persistence-jdbc] mdedetrich commented on pull request #44: Add Scala 3 support
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1628655679
@nafg So as you can see I have updated to the latest Slick 3 and not too surprisingly I am getting some compile errors. While I think that some of them are purely Scala 3 related (i.e. see https://contributors.scala-lang.org/t/better-type-inference-for-scala-send-us-your-problematic-cases/2410/186) others may be some combination of Slick/Scala3 i.e.
```
[error] 238 | def deleteAllFromDb() = db.run(queries.deleteAllFromDb())
[error] | ^
[error] |Double definition:
[error] |def deleteAllFromDb(): concurrent.Future[Int] in class JdbcDurableStateStore at line 238 and
[error] |def deleteAllFromDb(): concurrent.Future[Int] in class JdbcDurableStateStore at line 238
[error] |have the same type after erasure.
[error] |
[error] |Consider adding a @targetName annotation to one of the conflicting definitions
[error] |for disambiguation.
```
from https://github.com/mdedetrich/incubator-pekko-persistence-jdbc/blob/8e9b0129fe448b3601db1386f3cbaabf499ebda6/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L238
and
```
[error] -- [E120] Naming Error: /Users/mdedetrich/github/incubator-pekko-persistence-jdbc/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala:64:17
[error] 64 | final lazy val queries = new DurableStateQueries(profile, durableStateConfig)
[error] | ^
[error] |Double definition:
[error] |final lazy val queries:
[error] | org.apache.pekko.persistence.jdbc.state.DurableStateQueries in class JdbcDurableStateStore at line 64 and
[error] |final lazy val queries:
[error] | org.apache.pekko.persistence.jdbc.state.DurableStateQueries in class JdbcDurableStateStore at line 64
```
from https://github.com/mdedetrich/incubator-pekko-persistence-jdbc/blob/553dcbfe91030051f2139a5288be3c6280632780/core/src/main/scala/org/apache/pekko/persistence/jdbc/state/scaladsl/JdbcDurableStateStore.scala#L64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1983379492
@pjfanning Ready to review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#discussion_r1516084082
##########
core/src/main/mima-filters/1.1.x.backwards.excludes/slick.backwards.excludes:
##########
@@ -5,3 +5,38 @@ ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.s
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.snapshot.dao.legacy.SnapshotTables$SnapshotRow$")
ProblemFilters.exclude[MissingTypesProblem]("org.apache.pekko.persistence.jdbc.state.DurableStateTables$DurableStateRow$")
ProblemFilters.exclude[FinalMethodProblem]("org.apache.pekko.persistence.jdbc.state.scaladsl.JdbcDurableStateStore.queries")
+ProblemFilters.exclude[IncompatibleSignatureProblem]("org.apache.pekko.persistence.jdbc.db.EagerSlickDatabase.unapply")
Review Comment:
Okay I remember the context of the previous PR, we did pekko relevant changes to the API in order for it to compile with Slick 3.5.0 but still releasing with Slick 3.3.0.
So yes it should be a seperate file, I'll do this and add the headers as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1983327331
@mdedetrich Slick 3.5.0 is released
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1866147935
> @mdedetrich could you consider taking out the 'chore' changes and doing them in a separate PR that we can merge first?
>
> By chore, I mean the adding of type declarations to implicit vals and things of that nature.
Done, see https://github.com/apache/incubator-pekko-persistence-jdbc/pull/94
> @mdedetrich could you also update this PR to use Slick 3.3.0-M5 and Scala 3.3.1?
Done
Do note that this PR currently breaks binary compatibility so it should only be merged when we have a `1.0.x` branch setup, the PR at https://github.com/apache/incubator-pekko-persistence-jdbc/pull/94 adds the necessary MiMa filters
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1866162312
I'm happy enough for the 1.0.x to be created now.
When I said 'chore', I was implying just the 1.0.x friendly changes as opposed to the bin compatibility breaking changes - not a big deal though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Add Scala 3 support [incubator-pekko-persistence-jdbc]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #44:
URL: https://github.com/apache/incubator-pekko-persistence-jdbc/pull/44#issuecomment-1959052545
Marking PR as draft again, see https://github.com/slick/slick/discussions/2891#discussioncomment-8554394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org