You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/08/05 00:27:09 UTC
Review Request 37101: Remove unused sched API's
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/
-----------------------------------------------------------
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Repository: mesos
Description
-------
We don't use SCHED_IDLE any more.
Diffs
-----
src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
Diff: https://reviews.apache.org/r/37101/diff/
Testing
-------
make
Thanks,
Cong Wang
Re: Review Request 37101: Remove unused sched API's
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review94174
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36410, 36411, 36412, 36413, 37101]
All tests passed.
- Mesos ReviewBot
On Aug. 4, 2015, 10:27 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37101/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 10:27 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't use SCHED_IDLE any more.
>
>
> Diffs
> -----
>
> src/Makefile.am 54eaf205eecb6bf1a9a5c4b5ddad55f46ad635ec
> src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
> src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
>
> Diff: https://reviews.apache.org/r/37101/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37101: Remove unused sched API's
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review96263
-----------------------------------------------------------
Patch looks great!
Reviews applied: [36410, 36411, 36412, 36413, 37101]
All tests passed.
- Mesos ReviewBot
On Aug. 24, 2015, 9:30 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37101/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 9:30 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't use SCHED_IDLE any more.
>
>
> Diffs
> -----
>
> src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
> src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
> src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
>
> Diff: https://reviews.apache.org/r/37101/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37101: Remove unused sched API's
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review106954
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On Aug. 24, 2015, 2:30 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37101/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 2:30 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't use SCHED_IDLE any more.
>
>
> Diffs
> -----
>
> src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
> src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
> src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
>
> Diff: https://reviews.apache.org/r/37101/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37101: Remove unused sched API's
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review96266
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On Aug. 24, 2015, 9:30 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37101/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 9:30 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't use SCHED_IDLE any more.
>
>
> Diffs
> -----
>
> src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
> src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
> src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
>
> Diff: https://reviews.apache.org/r/37101/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37101: Remove unused sched API's
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/#review127852
-----------------------------------------------------------
Ship it!
Looks like this fell through the cracks :(
@cong: can you rebase this?
@idownes: can you land this?
- Vinod Kone
On Aug. 24, 2015, 9:30 p.m., Cong Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37101/
> -----------------------------------------------------------
>
> (Updated Aug. 24, 2015, 9:30 p.m.)
>
>
> Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> We don't use SCHED_IDLE any more.
>
>
> Diffs
> -----
>
> src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
> src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
> src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
>
> Diff: https://reviews.apache.org/r/37101/diff/
>
>
> Testing
> -------
>
> make
>
>
> Thanks,
>
> Cong Wang
>
>
Re: Review Request 37101: Remove unused sched API's
Posted by Cong Wang <cw...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37101/
-----------------------------------------------------------
(Updated Aug. 24, 2015, 9:30 p.m.)
Review request for mesos, Ian Downes, Jie Yu, and Vinod Kone.
Changes
-------
Rebase
Repository: mesos
Description
-------
We don't use SCHED_IDLE any more.
Diffs (updated)
-----
src/Makefile.am 9fd71d1ddf442712977596e7a13969ff5c1d68db
src/linux/sched.hpp 8cb06531b417a77766ab2b13587393b99a96b0c1
src/tests/containerizer/sched_tests.cpp 00723d01cd2cc37410d6f9fdd2de080063b7ccd8
Diff: https://reviews.apache.org/r/37101/diff/
Testing
-------
make
Thanks,
Cong Wang