You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by nsuke <gi...@git.apache.org> on 2016/02/27 08:45:21 UTC

[GitHub] thrift pull request: THRIFT-3686 Java processor should report inte...

GitHub user nsuke opened a pull request:

    https://github.com/apache/thrift/pull/904

    THRIFT-3686 Java processor should report internal error on uncaught exception

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nsuke/thrift THRIFT-3686

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/904.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #904
    
----
commit 1459231c57dc382b298a3a15c16797ea3a69e271
Author: John Sirois <js...@apache.org>
Date:   2016-02-08T20:04:36Z

    Fully parameterize java async client code.
    
    The parametrization brings the existing actual parametrization with
    client call implementation objects to the fore and so this change
    also fixes that parametrization to be a simple parametrization over
    the return type as is done in the server-side AsyncProcessor code.
    
    NB: This is a breaking change in both generated code and the client
    libs.

commit f32fe7664745238e5fc5e751233fa30bead1ea39
Author: Nobuaki Sukegawa <ns...@apache.org>
Date:   2016-02-27T07:03:21Z

    Follow-up THRIFT-3112: key.cancel when error

commit 7db35bc45a8e2c36c9239b29e0ca2cac07b08bef
Author: Nobuaki Sukegawa <ns...@apache.org>
Date:   2016-02-27T07:04:30Z

    THRIFT-3680 Java async processor fails to notify errors to clients

commit 7db9a9278de3c330e4de9226c227943f51f13203
Author: Nobuaki Sukegawa <ns...@apache.org>
Date:   2016-02-27T07:27:05Z

    THRIFT-3686 Java processor should report internal error on uncaught exception

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request #904: THRIFT-3686 Java processor should report internal ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/904


---

[GitHub] thrift issue #904: THRIFT-3686 Java processor should report internal error o...

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/904
  
    @nsuke This should be rebased against master since there are conflicts, and resubmitted; also see THRIFT-1805 as there is some discussion on what is okay and what is not in this context.


---

[GitHub] thrift issue #904: THRIFT-3686 Java processor should report internal error o...

Posted by jeking3 <gi...@git.apache.org>.
Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/904
  
    This should be rebased against upstream/master since there are conflicts, and resubmitted; also see THRIFT-1805 as there is some discussion on what is okay and what is not in this context.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---