You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-dev@jackrabbit.apache.org by "Joscorbe (via GitHub)" <gi...@apache.org> on 2025/08/03 12:39:28 UTC

[PR] OAK-11834: Add delay to getDefaultWriteConcern to avoid UNKWOWN ClusterType [jackrabbit-oak]

Joscorbe opened a new pull request, #2422:
URL: https://github.com/apache/jackrabbit-oak/pull/2422

   Newer versions of Mongo Java Driver can return ClusterType.UNKNOWN while the Mongo cluster is still initializing, failing some tests since the cluster is just started immediately.
   
   A simple solution could be to just add a delay to the test itself, but this is something that could happen in production too, meaning the WriteConcern would default to **ACKNOWLEDGED**, which would be wrong if it is actually running against a ReplicaSet.
   
   For this reason, I'm adding a configurable delay of 5 seconds with retry to the `getDefaultWriteConcern` method. This should have no impact in most situations, since it's quite strange the Mongo cluster is not completely running when Oak tries to connect to it. 
   Normal initialization time for Mongo clusters is around 3 seconds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11834: Add delay to getDefaultWriteConcern to avoid UNKNOWN ClusterType [jackrabbit-oak]

Posted by "Joscorbe (via GitHub)" <gi...@apache.org>.

Joscorbe merged PR #2422:
URL: https://github.com/apache/jackrabbit-oak/pull/2422


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11834: Add delay to getDefaultWriteConcern to avoid UNKWOWN ClusterType [jackrabbit-oak]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #2422:
URL: https://github.com/apache/jackrabbit-oak/pull/2422#issuecomment-3148396311

   # Commit-Check ✔️


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] OAK-11834: Add delay to getDefaultWriteConcern to avoid UNKNOWN ClusterType [jackrabbit-oak]

Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.

sonarqubecloud[bot] commented on PR #2422:
URL: https://github.com/apache/jackrabbit-oak/pull/2422#issuecomment-3148465573

   ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate Failed')](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2422) **Quality Gate failed**  
   Failed conditions  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [77.1% Coverage on New Code](https://sonarcloud.io/component_measures?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2422&metric=new_coverage&view=list) (required ≥ 80%)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/failed-16px.png '') [C Reliability Rating on New Code](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2422) (required ≥ A)  
     
   [See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=org.apache.jackrabbit%3Ajackrabbit-oak&pullRequest=2422)
   
   ##   
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/light_bulb-16px.png '') Catch issues before they fail your Quality Gate with our IDE extension ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/sonarlint-16px.png '') [SonarQube for IDE](https://www.sonarsource.com/products/sonarlint/features/connected-mode/?referrer=pull-request)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org