svn commit: r1738413 - in /poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming: SXSSFSheet.java SXSSFWorkbook.java

[ce...@apache.org]

Author: centic
Date: Sun Apr 10 09:40:40 2016
New Revision: 1738413

URL: http://svn.apache.org/viewvc?rev=1738413&view=rev
Log:
Bug 57844: Add some javadoc for unimplemented features in SXSSF

Modified:
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
    poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java?rev=1738413&r1=1738412&r2=1738413&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFSheet.java Sun Apr 10 09:40:40 2016
@@ -1313,10 +1313,13 @@ public class SXSSFSheet implements Sheet
     }
 
     /**
-     * Set view state of a groupped range of rows
+     * Set view state of a grouped range of rows.
+     *
+     * <i>Not implemented for expanding (i.e. collapse == false)</i>
      *
      * @param row   start row of a groupped range of rows (0-based)
      * @param collapse whether to expand/collapse the detail rows
+     * @throws RuntimeException if collapse is false as this is not implemented for SXSSF.
      */
     @Override
     public void setRowGroupCollapsed(int row, boolean collapse)

Modified: poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java
URL: http://svn.apache.org/viewvc/poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java?rev=1738413&r1=1738412&r2=1738413&view=diff
==============================================================================
--- poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java (original)
+++ poi/trunk/src/ooxml/java/org/apache/poi/xssf/streaming/SXSSFWorkbook.java Sun Apr 10 09:40:40 2016
@@ -47,6 +47,7 @@ import org.apache.poi.ss.usermodel.Pictu
 import org.apache.poi.ss.usermodel.Row.MissingCellPolicy;
 import org.apache.poi.ss.usermodel.Sheet;
 import org.apache.poi.ss.usermodel.Workbook;
+import org.apache.poi.util.NotImplemented;
 import org.apache.poi.util.POILogFactory;
 import org.apache.poi.util.POILogger;
 import org.apache.poi.util.TempFile;
@@ -645,6 +646,7 @@ public class SXSSFWorkbook implements Wo
     {
         return createAndRegisterSXSSFSheet(_wb.createSheet());
     }
+
     SXSSFSheet createAndRegisterSXSSFSheet(XSSFSheet xSheet)
     {
         final SXSSFSheet sxSheet;
@@ -675,11 +677,14 @@ public class SXSSFWorkbook implements Wo
     }
 
     /**
+     * <i>Not implemented for SXSSFWorkbook</i>
+     *
      * Create an Sheet from an existing sheet in the Workbook.
      *
      * @return Sheet representing the cloned sheet.
      */
     @Override
+    @NotImplemented
     public Sheet cloneSheet(int sheetNum)
     {
         throw new RuntimeException("NotImplemented");
@@ -1268,6 +1273,8 @@ public class SXSSFWorkbook implements Wo
     }
     
     /**
+     * <i>Not implemented for SXSSFWorkbook</i>
+     *
      * Adds the LinkTable records required to allow formulas referencing
      *  the specified external workbook to be added to this one. Allows
      *  formulas such as "[MyOtherWorkbook]Sheet3!$A$5" to be added to the 
@@ -1276,6 +1283,8 @@ public class SXSSFWorkbook implements Wo
      * @param name The name the workbook will be referenced as in formulas
      * @param workbook The open workbook to fetch the link required information from
      */
+    @Override
+    @NotImplemented
     public int linkExternalWorkbook(String name, Workbook workbook) {
         throw new RuntimeException("NotImplemented");
     }



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org