You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/12/21 20:36:13 UTC
[GitHub] [iceberg] rdblue opened a new pull request #1971: Add separate CI steps for javadoc and errorprone/checkstyle
rdblue opened a new pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue merged pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle
Posted by GitBox <gi...@apache.org>.
rdblue merged pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971#discussion_r550489696
##########
File path: .github/workflows/java-ci.yml
##########
@@ -37,11 +37,28 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew check
+ - run: ./gradlew check -Pquick=true -x javadoc
- uses: actions/upload-artifact@v2
if: failure()
with:
name: test logs
path: |
**/build/testlogs
+ extra-checks:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: 8
Review comment:
Alright with me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on a change in pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on a change in pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971#discussion_r547889582
##########
File path: .github/workflows/java-ci.yml
##########
@@ -37,11 +37,28 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew check
+ - run: ./gradlew check -Pquick=true -x javadoc
- uses: actions/upload-artifact@v2
if: failure()
with:
name: test logs
path: |
**/build/testlogs
+ extra-checks:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: 8
Review comment:
Are we going to do these checks with java 8 only?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on a change in pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle
Posted by GitBox <gi...@apache.org>.
rdblue commented on a change in pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971#discussion_r548268833
##########
File path: .github/workflows/java-ci.yml
##########
@@ -37,11 +37,28 @@ jobs:
path: ~/.gradle/caches
key: ${{ runner.os }}-gradle-${{ hashFiles('**/*.gradle') }}
restore-keys: ${{ runner.os }}-gradle
- - run: ./gradlew check
+ - run: ./gradlew check -Pquick=true -x javadoc
- uses: actions/upload-artifact@v2
if: failure()
with:
name: test logs
path: |
**/build/testlogs
+ extra-checks:
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v2
+ - uses: actions/setup-java@v1
+ with:
+ java-version: 8
Review comment:
Yes. I think that errorprone and checkstyle should be the same across both.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] rdblue commented on pull request #1971: Build: Add separate CI jobs for javadoc and errorprone/checkstyle
Posted by GitBox <gi...@apache.org>.
rdblue commented on pull request #1971:
URL: https://github.com/apache/iceberg/pull/1971#issuecomment-749681306
Looks like this does speed up the test runs a bit. Comparing with another job, I see 62m vs 80m for Java 8, and 27m vs 32m for Java 11.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org