You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2023/05/19 08:22:25 UTC
[ofbiz-framework] 02/02: Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480)
This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch release22.01
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit 1786d92df3c1ab4d22d4e668307b5a5e1489293d
Author: Jacques Le Roux <ja...@les7arts.com>
AuthorDate: Fri May 19 09:51:58 2023 +0200
Fixed: Reducing scope of variables in common and base packages (OFBIZ-10477) (OFBIZ-10480)
Following https://lists.apache.org/thread/g1z92gtlf9p1rxlc247yg2zqd6bczq7s
conversation, this fixes SAFE util methods being transformed to private
when obviously they should be public
Thanks: Michael for spotting, reporting and confirming it's OK
---
.../org/apache/ofbiz/base/util/UtilFormatOut.java | 27 ++++++++++++++--------
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java
index e769f74abf..f26925b143 100644
--- a/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java
+++ b/framework/base/src/main/java/org/apache/ofbiz/base/util/UtilFormatOut.java
@@ -117,11 +117,14 @@ public final class UtilFormatOut {
return formatNumber(price, AMOUNT_FORMAT, null, null);
}
- /** Formats a double into a properly formatted currency string based on isoCode and Locale
- * @param price The price double to be formatted
- * @param isoCode the currency ISO code
- * @param locale The Locale used to format the number
- * @param maximumFractionDigits The maximum number of fraction digits used; if set to -1 than the default value for the locale is used
+ /**
+ * Formats a double into a properly formatted currency string based on isoCode and Locale
+ *
+ * @param price The price double to be formatted
+ * @param isoCode the currency ISO code
+ * @param locale The Locale used to format the number
+ * @param maximumFractionDigits The maximum number of fraction digits used; if
+ * set to -1 than the default value for the locale
* @return A String with the formatted price
*/
public static String formatCurrency(double price, String isoCode, Locale locale, int maximumFractionDigits) {
@@ -139,11 +142,15 @@ public final class UtilFormatOut {
return nf.format(price);
}
- /** Formats a BigDecimal into a properly formatted currency string based on isoCode and Locale
- * @param price The price BigDecimal to be formatted
- * @param isoCode the currency ISO code
- * @param locale The Locale used to format the number
- * @param maximumFractionDigits The maximum number of fraction digits used; if set to -1 than the default value for the locale is used
+ /**
+ * Formats a double into a properly formatted currency string based on isoCode and Locale
+ *
+ * @param price The price BigDecimal to be formatted
+ * @param isoCode the currency ISO code
+ * @param locale The Locale used to format the number
+ * @param maximumFractionDigits The maximum number of fraction digits used; if
+ * set to -1 than the default value for the locale
+ * is used
* @return A String with the formatted price
*/
public static String formatCurrency(BigDecimal price, String isoCode, Locale locale, int maximumFractionDigits) {