You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/08/09 14:17:28 UTC

[commons-codec] branch master updated: Bump maven-checkstyle-plugin from 2.17 to 3.1.2.

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-codec.git


The following commit(s) were added to refs/heads/master by this push:
     new b7ba05a  Bump maven-checkstyle-plugin from 2.17 to 3.1.2.
b7ba05a is described below

commit b7ba05ad6b99ae9d5f93cd18e936b3e8908202fb
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Aug 9 10:17:25 2021 -0400

    Bump maven-checkstyle-plugin from 2.17 to 3.1.2.
---
 pom.xml                 | 12 ++++++++++--
 src/changes/changes.xml |  1 +
 src/conf/checkstyle.xml |  6 +++---
 3 files changed, 14 insertions(+), 5 deletions(-)

diff --git a/pom.xml b/pom.xml
index add0a79..73f8074 100644
--- a/pom.xml
+++ b/pom.xml
@@ -257,7 +257,8 @@ limitations under the License.
     <commons.encoding>UTF-8</commons.encoding>
     <checkstyle.header.file>${basedir}/src/conf/checkstyle-header.txt</checkstyle.header.file>
     <checkstyle.config.file>${basedir}/src/conf/checkstyle.xml</checkstyle.config.file>
-    <checkstyle.version>2.17</checkstyle.version>
+    <commons.checkstyle-plugin.version>3.1.2</commons.checkstyle-plugin.version>
+    <commons.checkstyle.version>8.45.1</commons.checkstyle.version>
     <commons.japicmp.version>0.15.3</commons.japicmp.version>
     <commons.jacoco.version>0.8.7</commons.jacoco.version>
     <commons.javadoc.version>3.3.0</commons.javadoc.version>
@@ -294,7 +295,14 @@ limitations under the License.
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>${checkstyle.version}</version>
+          <version>${commons.checkstyle-plugin.version}</version>
+          <dependencies>
+            <dependency>
+              <groupId>com.puppycrawl.tools</groupId>
+              <artifactId>checkstyle</artifactId>
+              <version>${commons.checkstyle.version}</version>
+            </dependency>
+          </dependencies>
           <configuration>
             <configLocation>${checkstyle.config.file}</configLocation>
             <enableRulesSummary>false</enableRulesSummary>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 0d60289..fe70cc1 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -63,6 +63,7 @@ The <action> type attribute can be add,update,fix,remove.
       <action                   dev="ggregory" type="update" due-to="Gary Gregory">Bump maven-javadoc-plugin from 3.2.0 to 3.3.0.</action>
       <action                   dev="ggregory" type="update" due-to="Gary Gregory">Bump animal-sniffer-maven-plugin from 1.19 to 1.20.</action>
       <action                   dev="ggregory" type="update" due-to="Gary Gregory">Bump maven-pmd-plugin from 3.13.0 to 3.14.0.</action>
+      <action                   dev="ggregory" type="update" due-to="Gary Gregory">Bump maven-checkstyle-plugin from 2.17 to 3.1.2.</action>
     </release>
 
     <release version="1.15" date="2020-09-01" description="Feature and fix release.">
diff --git a/src/conf/checkstyle.xml b/src/conf/checkstyle.xml
index 0d686a5..ddb492a 100644
--- a/src/conf/checkstyle.xml
+++ b/src/conf/checkstyle.xml
@@ -60,15 +60,15 @@ limitations under the License.
   </module>
 
   <module name="TreeWalker">
-    <property name="cacheFile" value="target/cachefile" />
     <module name="OperatorWrap">
       <property name="option" value="eol" />
     </module>
-    <module name="LineLength">
+  </module>
+
+  <module name="LineLength">
       <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
       <property name="ignorePattern" value="^ *\* *[^ ]"/>
       <property name="max" value="120"/>
-    </module>
   </module>
 
 </module>