You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/02/08 10:31:39 UTC

[GitHub] uce opened a new pull request #7668: [FLINK-11545] [container] Add job-id arg to StandaloneJobClusterEntryPoint

uce opened a new pull request #7668: [FLINK-11545] [container] Add job-id arg to StandaloneJobClusterEntryPoint
URL: https://github.com/apache/flink/pull/7668
 
 
   ## What is the purpose of the change
   
   - This PR adds the optional `--job-id` command line argument to the `StandaloneJobClusterEntryPoint`
     - If specified, users manually set the job ID of the job
     - If not specified, the job ID of the job is all zeros (current behavior)
   
   ## Brief change log
   
   - Parse job ID option in `StandaloneJobClusterConfigurationParserFactory` 
   - Provide job ID in `ClassPathJobGraphRetriever` constructor
   - Catch `Throwable` when parsing command line args as a safety net and have a good error message in the logs
   
   ## Verifying this change
   
   - This change added unit tests for added functionality
   - If you want to manually verify this change, you can follow these steps:
     1. Build this branch
     2. Copy `examples/streaming/TopSpeedWindowing.jar` to `lib`
     3. Execute `bin/standalone-job.sh start --job-classname org.apache.flink.streaming.examples.windowing.TopSpeedWindowing` (expected: job ID is all zeros)
     4. Execute `bin/standalone-job.sh start --job-classname org.apache.flink.streaming.examples.windowing.TopSpeedWindowing --job-id fd72014d4c864993a2e5a9287b4a9c5d` (expected: job ID fd72014d4c864993a2e5a9287b4a9c5d)
     5. Execute `bin/standalone-job.sh start --job-classname org.apache.flink.streaming.examples.windowing.TopSpeedWindowing --job-id INVALID_JOB_ID` (expected: logs with error message)
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: yes (it adds a new command line argument which is part of the extended API)
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: no
   - The S3 file system connector: no
   
   ## Documentation
   
   - Added note about new command line arg in `flink-container/kubernetes/README.md`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services