You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2024/01/15 18:17:00 UTC
[jira] [Commented] (HDDS-9985) Do not use Guava Optional
[ https://issues.apache.org/jira/browse/HDDS-9985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17806933#comment-17806933 ]
Attila Doroszlai commented on HDDS-9985:
----------------------------------------
Current usage:
{code}
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/cache/CacheValue.java
21:import com.google.common.base.Optional;
56: public CacheValue(Optional<VALUE> value, long epoch) {
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMultiTenantManagerImpl.java
42:import com.google.common.base.Optional;
831: public Optional<String> getTenantForAccessID(String accessID)
836: return Optional.absent();
838: return Optional.of(omDBAccessIdInfo.getTenantId());
848: final Optional<String> optionalTenant = getTenantForAccessID(accessId);
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMMultiTenantManager.java
24:import com.google.common.base.Optional;
144: Optional<String> getTenantForAccessID(String accessID) throws IOException;
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
54:import com.google.common.base.Optional;
3497: final Optional<String> optionalTenantId = isS3MultiTenancyEnabled() ?
3498: multiTenantManager.getTenantForAccessID(accessId) : Optional.absent();
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyRequest.java
36:import com.google.common.base.Optional;
285: protected static Optional<FileEncryptionInfo> getFileEncryptionInfo(
287: Optional<FileEncryptionInfo> encInfo = Optional.absent();
292: encInfo = Optional.of(new FileEncryptionInfo(ezInfo.getSuite(),
555: Optional<FileEncryptionInfo> encryptionInfo =
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/multipart/S3ExpiredMultipartUploadsAbortRequest.java
22:import com.google.common.base.Optional;
315: new CacheValue<>(Optional.absent(), trxnLogIndex));
319: new CacheValue<>(Optional.absent(), trxnLogIndex));
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/security/S3SecretRequestHelper.java
20:import com.google.common.base.Optional;
84: final Optional<String> optionalTenantId =
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantAssignAdminRequest.java
21:import com.google.common.base.Optional;
90: Optional<String> optionalTenantId =
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRevokeAdminRequest.java
21:import com.google.common.base.Optional;
90: Optional<String> optionalTenantId =
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/s3/tenant/OMTenantRevokeUserAccessIdRequest.java
21:import com.google.common.base.Optional;
108: Optional<String> optionalTenantId =
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/multipart/TestS3ExpiredMultipartUploadsAbortRequest.java
29:import com.google.common.base.Optional;
661: new CacheValue<>(Optional.absent(), 100L));
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/s3/security/TestS3GetSecretRequest.java
72:import com.google.common.base.Optional;
175: .thenReturn(Optional.absent());
177: .thenReturn(Optional.absent());
179: .thenReturn(Optional.of(ACCESS_ID_BOB));
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/request/security/TestOMGetDelegationTokenRequest.java
23:import com.google.common.base.Optional;
189: Optional<Long> responseRenewTime = Optional.fromNullable(
191: assertEquals(Optional.of(renewTime), responseRenewTime);
207: Optional<Long> responseRenewTime = Optional.fromNullable(
209: assertEquals(Optional.absent(), responseRenewTime);
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOMMultiTenantManagerImpl.java
39:import com.google.common.base.Optional;
167: Optional<String> optionalTenant = tenantManager.getTenantForAccessID(
{code}
* Usage in {{CacheValue}} can be removed, the method was deprecated in 1.4.0. Callers in {{S3ExpiredMultipartUploadsAbortRequest}} and its test can be changed to the other constructor. Similarly for mock in {{TestS3GetSecretRequest}}.
* {{OMMultiTenantManagerImpl#getTenantForAccessID}} and its callers should be changed to {{java.util.Optional}}.
* {{TestOMGetDelegationTokenRequest}} can avoid the use of {{Optional}} completely by using {{Long}} directly.
> Do not use Guava Optional
> -------------------------
>
> Key: HDDS-9985
> URL: https://issues.apache.org/jira/browse/HDDS-9985
> Project: Apache Ozone
> Issue Type: Improvement
> Reporter: Tsz-wo Sze
> Assignee: Raju Balpande
> Priority: Major
>
> Guava Optional (com.google.common.base.Optional) should be replaced by java.util.Optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org