You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@hive.apache.org by GitBox <gi...@apache.org> on 2020/04/29 12:13:37 UTC
[GitHub] [hive] kgyrtkirk opened a new pull request #1000: HIVE-23323 qsplits
kgyrtkirk opened a new pull request #1000:
URL: https://github.com/apache/hive/pull/1000
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1000: HIVE-23323 qsplits
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1000:
URL: https://github.com/apache/hive/pull/1000#issuecomment-868947655
@trevino3000 what are you up to?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on pull request #1000: HIVE-23323 qsplits
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on pull request #1000:
URL: https://github.com/apache/hive/pull/1000#issuecomment-622297049
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #1000: HIVE-23323 qsplits
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #1000:
URL: https://github.com/apache/hive/pull/1000#discussion_r419613747
##########
File path: itests/bin/generate-cli-splits.sh
##########
@@ -0,0 +1,26 @@
+#!/bin/bash
+
+usage() {
+ echo "$0 <from> <to>"
+ exit 1
+}
+
+[ "$1" == "" ] && usage
+[ "$2" == "" ] && usage
+
+
+inDir="$1"
+outDir="$2"
+
+git grep SplitSupport.process | grep "$1" | cut -d ':' -f1|while read f;do
Review comment:
As I see in this model the number of batches would be fixed, not the number of tests in a batch. I see why is this useful for generating the files, but it would be better to fix the batch size.
How the isolated tests are going to be handled?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] kgyrtkirk commented on a change in pull request #1000: HIVE-23323 qsplits
Posted by GitBox <gi...@apache.org>.
kgyrtkirk commented on a change in pull request #1000:
URL: https://github.com/apache/hive/pull/1000#discussion_r419670022
##########
File path: itests/util/src/test/java/org/apache/hadoop/hive/cli/control/TestSplitSupport.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.cli.control;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Test;
+
+import com.google.common.collect.Sets;
+
+public class TestSplitSupport {
+
+ @Test
+ public void testSplitParams() {
Review comment:
removed it
##########
File path: itests/qtest-spark/pom.xml
##########
@@ -417,5 +417,53 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
Review comment:
I don't know why my editor switched to 4 spaces...
##########
File path: itests/bin/generate-cli-splits.sh
##########
@@ -0,0 +1,26 @@
+#!/bin/bash
+
+usage() {
+ echo "$0 <from> <to>"
+ exit 1
+}
+
+[ "$1" == "" ] && usage
+[ "$2" == "" ] && usage
+
+
+inDir="$1"
+outDir="$2"
+
+git grep SplitSupport.process | grep "$1" | cut -d ':' -f1|while read f;do
Review comment:
yes the number of batches will be fixed; and it will have nothing to do with the number of batches in a test suite.
I've considered a highly sophisticated one prior to ending up with this solution (which was also inherently complex as well)...after some time I concluded that actually there is no big gain from making it "very good"...if all testclasses will be below say 30 minutes it will be good enough.
So the goal of this thing is not to make the perfect sized split; but to make them run under say N minutes; when I've calibrated the actual split counts I tried to go for ~15 minutes so it will take some time when it will needs adjusting from time-to-time.
About isolated tests: this patch doesn't tries to address that - right now I think the option to put tests into "isolation" will not be supported anymore. The best would be to fix them but putting them on ignore could be also an option...
Right now I don't see any easy way to define "isolated" suites...however....it could be probably forced into this splits logic in some way...for now I think let's fix or ignore them - later we can get back to this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org
[GitHub] [hive] miklosgergely commented on a change in pull request #1000: HIVE-23323 qsplits
Posted by GitBox <gi...@apache.org>.
miklosgergely commented on a change in pull request #1000:
URL: https://github.com/apache/hive/pull/1000#discussion_r419610881
##########
File path: itests/qtest-spark/pom.xml
##########
@@ -417,5 +417,53 @@
</plugin>
</plugins>
</build>
-
+ <profiles>
Review comment:
Please use 2 spaces as indentation, to keep consistency
##########
File path: itests/qtest/pom.xml
##########
@@ -426,15 +426,62 @@
<scope>test</scope>
</dependency>
</dependencies>
- <profiles>
- <profile>
- <!-- replaces -Dclustermode=minimr which I am sure sure was used? -->
- <id>minimr</id>
- <properties>
- <test.warehouse.scheme></test.warehouse.scheme>
- </properties>
- </profile>
- </profiles>
+ <profiles>
Review comment:
Please use 2 spaces as indentation, to keep consistency
##########
File path: itests/util/src/test/java/org/apache/hadoop/hive/cli/control/TestSplitSupport.java
##########
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.cli.control;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Set;
+
+import org.junit.Test;
+
+import com.google.common.collect.Sets;
+
+public class TestSplitSupport {
+
+ @Test
+ public void testSplitParams() {
Review comment:
What is this test for?
##########
File path: itests/bin/generate-cli-splits.sh
##########
@@ -0,0 +1,26 @@
+#!/bin/bash
+
+usage() {
+ echo "$0 <from> <to>"
+ exit 1
+}
+
+[ "$1" == "" ] && usage
+[ "$2" == "" ] && usage
+
+
+inDir="$1"
+outDir="$2"
+
+git grep SplitSupport.process | grep "$1" | cut -d ':' -f1|while read f;do
Review comment:
Nit: Please be consistent about putting two spaces next to the | characters when they are used as pipeline separators.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org