[jira] [Comment Edited] (HBASE-14249) shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE info

["Andrew Purtell (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-14249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14704059#comment-14704059 ] 

Andrew Purtell edited comment on HBASE-14249 at 8/20/15 12:45 AM:
------------------------------------------------------------------

No RAT problems if following the steps documented in http://hbase.apache.org/book.html#releasing . (I didn't do 'deploy' though.) This is with master branch with the patch on this issue applied. 

We don't included shaded jars in the assembly it seems. Pardon, my head is still back with 0.98 and 1.0. Therefore the issue is, assuming we have the patch on this issue applied, that we end up uploading an empty hbase-shaded-*-tests jar to Nexus with a 0 length NOTICE, is that right? Is that really a blocker? Agreed its ugly and should be fixed longer term. Maybe there's a way to exclude them from the deploy goal.




was (Author: apurtell):
No RAT problems if following the steps documented in http://hbase.apache.org/book.html#releasing . (I didn't do 'deploy' though.) This is with master branch with the patch on this issue applied. 

We don't included shaded jars in the assembly it seems. Pardon, my head is still back with 0.98 and 1.0. Therefore the issue is, assuming we have the patch on this issue applied, that will upload an empty hbase-shaded-*-tests jar to Nexus with a 0 length NOTICE, is that right? Is that really a blocker? Agreed its ugly and should be fixed longer term. Maybe there's a way to exclude them from the deploy goal.



> shaded jar modules create spurious source and test jars with incorrect LICENSE/NOTICE info
> ------------------------------------------------------------------------------------------
>
>                 Key: HBASE-14249
>                 URL: https://issues.apache.org/jira/browse/HBASE-14249
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.3.0
>            Reporter: Sean Busbey
>            Priority: Blocker
>         Attachments: HBASE-14249.patch, HBASE-14249.patch, HBASE-14249.patch, effective-pom.xml
>
>
> the shaded jar modules don't need to create a source or test jar (because the jars contain nothing other than META-INF)
> currently we create 
>  * the test jars are missing LICENSE
>  * source jars have LICENSE/NOTICE files that claim all the bundled works in the normal jar.
> {code}
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar/
> hbase-shaded-server-1.1.2-sources.jar//META-INF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-server-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-server-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar/
> hbase-shaded-client-1.1.2-sources.jar//META-INF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/LICENSE
> hbase-shaded-client-1.1.2-sources.jar//META-INF/MANIFEST.MF
> hbase-shaded-client-1.1.2-sources.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar/
> hbase-shaded-client-1.1.2-tests.jar//META-INF
> hbase-shaded-client-1.1.2-tests.jar//META-INF/NOTICE
> hbase-1.1.2-rc0 busbey$ find hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar/
> hbase-shaded-server-1.1.2-tests.jar//META-INF
> hbase-shaded-server-1.1.2-tests.jar//META-INF/NOTICE
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)