You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "bryancall (via GitHub)" <gi...@apache.org> on 2023/11/28 20:29:38 UTC
[PR] Coverity 1497378: Use of 32-bit time_t in CacheVC [trafficserver]
bryancall opened a new pull request, #10857:
URL: https://github.com/apache/trafficserver/pull/10857
In `CacheVC::set_pin_in_cache()` `time_pin` of type `time_t` is being assigned to a `pin_in_cache` which was an `uint32_t`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497378: Use of 32-bit time_t in CacheVC [trafficserver]
Posted by "bryancall (via GitHub)" <gi...@apache.org>.
bryancall merged PR #10857:
URL: https://github.com/apache/trafficserver/pull/10857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Coverity 1497378: Use of 32-bit time_t in CacheVC [trafficserver]
Posted by "masaori335 (via GitHub)" <gi...@apache.org>.
masaori335 commented on PR #10857:
URL: https://github.com/apache/trafficserver/pull/10857#issuecomment-1831053008
It looks like when I reverted https://github.com/apache/trafficserver/commit/822172a339bc7fcbcabb6a9ebb2df4433b3bf8bc by https://github.com/apache/trafficserver/commit/595c1ec6f3886b1916a0e617589b7a423a2f9338, I reverted too much.
Please remove these casts and coverity suppressions with this change.
https://github.com/apache/trafficserver/blob/959a1b8aac2eb0bfc2ce176fcbc0b3e89c84cc62/src/iocore/cache/CacheWrite.cc#L1594-L1595
https://github.com/apache/trafficserver/blob/959a1b8aac2eb0bfc2ce176fcbc0b3e89c84cc62/src/iocore/cache/CacheWrite.cc#L1696-L1697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org