You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "ggodik (via GitHub)" <gi...@apache.org> on 2023/09/06 15:28:03 UTC
[GitHub] [arrow] ggodik opened a new issue, #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
ggodik opened a new issue, #37590:
URL: https://github.com/apache/arrow/issues/37590
### Describe the enhancement requested
Prefer to return an `error` instead of `panic` as this situation is due to a bad user input.
Change the signature to return a `Schema`/`Metadata` and an `error`
list of `panic`s
- https://github.com/apache/arrow/blob/main/go/arrow/schema.go#L182
- https://github.com/apache/arrow/blob/main/go/arrow/schema.go#L34
### Component(s)
Go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on issue #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #37590:
URL: https://github.com/apache/arrow/issues/37590#issuecomment-1708985713
@ggodik yes, but we've been maintaining compatibility with go1.17 still via build tags. Sections like the compute lib which used generics have had build tags to ensure that they would simply be excluded in go1.17 builds and we have CI still building that version.
So i'd be fine with removing the go1.17 CI builds and officially dropping support for it now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zeroshade commented on issue #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
Posted by "zeroshade (via GitHub)" <gi...@apache.org>.
zeroshade commented on issue #37590:
URL: https://github.com/apache/arrow/issues/37590#issuecomment-1708885394
I like it. Besides i think it's time we start leveraging generics in the arrow lib and bump to go1.18 anyways :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ggodik commented on issue #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
Posted by "ggodik (via GitHub)" <gi...@apache.org>.
ggodik commented on issue #37590:
URL: https://github.com/apache/arrow/issues/37590#issuecomment-1708642940
I'm working on a PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ggodik commented on issue #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
Posted by "ggodik (via GitHub)" <gi...@apache.org>.
ggodik commented on issue #37590:
URL: https://github.com/apache/arrow/issues/37590#issuecomment-1708865635
@zeroshade
there's a lot of places where `arrow.NewSchema` is inlined in unit tests
what do you think about a helper to wrap it
```
// NoError is a helper function that asserts that the error is nil and returns the value.
func NoError[S any](t *testing.T) func(s S, err error) S {
return func(s S, err error) S {
assert.NoError(t, err)
return s
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ggodik commented on issue #37590: [Go][Arrow] Remove `panic` from `arrow.Schema` and `arrow.Metadata` construction
Posted by "ggodik (via GitHub)" <gi...@apache.org>.
ggodik commented on issue #37590:
URL: https://github.com/apache/arrow/issues/37590#issuecomment-1708900894
The `mod` file is already at 1.20 https://github.com/apache/arrow/blob/main/go/go.mod#L19C1-L19C8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org