You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/02/11 08:09:11 UTC
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1926: Fix incorrect sorting of ZooLock child nodes
ctubbsii commented on a change in pull request #1926:
URL: https://github.com/apache/accumulo/pull/1926#discussion_r574307982
##########
File path: core/src/main/java/org/apache/accumulo/fate/AdminUtil.java
##########
@@ -63,7 +63,6 @@ public AdminUtil() {
* <code>System.exit(1)</code> on error if true
*/
public AdminUtil(boolean exitOnError) {
- super();
Review comment:
This was removed by my editor as redundant when I saved the file.
##########
File path: core/src/main/java/org/apache/accumulo/fate/AdminUtil.java
##########
@@ -293,12 +292,10 @@ private void findLocks(ZooReader zk, final String lockPath,
if (pos == 0) {
locks = heldLocks;
+ } else if (lda[0].charAt(0) == 'R' && !sawWriteLock) {
+ locks = heldLocks;
} else {
- if (lda[0].charAt(0) == 'R' && !sawWriteLock) {
- locks = heldLocks;
- } else {
- locks = waitingLocks;
- }
+ locks = waitingLocks;
Review comment:
This was converted by my editor as redundant when I saved the file, and is clearly better, so I kept it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org