You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/21 21:48:03 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5677: Move `TaskContext` to datafusion-execution
alamb opened a new pull request, #5677:
URL: https://github.com/apache/arrow-datafusion/pull/5677
# Which issue does this PR close?
Part of https://github.com/apache/arrow-datafusion/issues/1754
# Rationale for this change
I am trying to extract the physical_plan code into its own crate; and to do so I need to remove the circular dependencies between core --> datasource --> execution --> datasource
The `TaskContext` is the part of the `SessionState` that is used at runtime, so it must be in the `datafusion_execution` crate. After this the next step will be to pull out datasource into its own crate (and only depend on datafusion_execution)
See more details in https://github.com/apache/arrow-datafusion/issues/1754#issuecomment-1452438453
# What changes are included in this PR?
1. Move `TaskContext` to `datafusion_execution`
3. Mark `TaskContext::try_new()` as deprecated (we now have `SessionConfig` that works better)
# Are these changes tested?
Covered by existing tests
# Are there any user-facing changes?
I added a `pub use` so this code movement should not affect users other than the deprecated API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5677: Move `TaskContext` to datafusion-execution
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5677:
URL: https://github.com/apache/arrow-datafusion/pull/5677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5677: Move `TaskContext` to datafusion-execution
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5677:
URL: https://github.com/apache/arrow-datafusion/pull/5677#discussion_r1144023089
##########
datafusion/common/src/config.rs:
##########
@@ -561,6 +561,11 @@ pub trait ExtensionOptions: Send + Sync + std::fmt::Debug + 'static {
pub struct Extensions(BTreeMap<&'static str, ExtensionBox>);
impl Extensions {
+ /// Create a new, empty [`Extensions`]
Review Comment:
This was part of https://github.com/apache/arrow-datafusion/pull/5676 that I didn't want to lose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5677: Move `TaskContext` to datafusion-execution
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5677:
URL: https://github.com/apache/arrow-datafusion/pull/5677#discussion_r1144023267
##########
datafusion/core/src/execution/context.rs:
##########
@@ -1802,74 +1802,6 @@ impl OptimizerConfig for SessionState {
}
}
-/// Task Execution Context
Review Comment:
this PR simply moves this code into datafusion_execution
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org