You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oodt.apache.org by Sheryl John <sh...@gmail.com> on 2012/04/18 19:15:08 UTC
Review Request: Rollback capability for workflows
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/
-----------------------------------------------------------
Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Summary
-------
First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
Diffs
-----
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
Diff: https://reviews.apache.org/r/4790/diff
Testing
-------
none
Thanks,
Sheryl
Re: Review Request: Rollback capability for workflows
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7035
-----------------------------------------------------------
You might also want to tie this to the associated JIRA issue. You can just put in the bug ID for it and link to it.
- Chris
On 2012-04-18 17:15:08, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-18 17:15:08)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7034
-----------------------------------------------------------
Great first iteration, Sheryl, keep em coming!
- Chris
On 2012-04-18 17:15:08, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-18 17:15:08)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Sheryl John <sh...@gmail.com>.
> On 2012-04-22 04:00:35, Chris Mattmann wrote:
> > https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java, line 74
> > <https://reviews.apache.org/r/4790/diff/2/?file=103877#file103877line74>
> >
> > Not sure this has to be an abstract method if its purpose (as I am thinking about it -- correct me if I'm wrong) is to clear the workflow instance entry out of the repository (because in #clearAllMetadata, you are clearing the inst met). I would just make this a similarly protected method and implement it. IOW, you have a handle to the wm with wmc, so just use it to remove the inst from the repo.
You're right and I'll change it to remove the inst from the rep. I had initially intended it for clearing a task instance from the workflow processor.
- Sheryl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7117
-----------------------------------------------------------
On 2012-04-22 03:39:06, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-22 03:39:06)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> This addresses bug OODT-212.
> https://issues.apache.org/jira/browse/OODT-212
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7117
-----------------------------------------------------------
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java
<https://reviews.apache.org/r/4790/#comment15735>
Since we are asking sub-classes to implement this method, you might consider using the new WorkflowState class as an explicit parameter, and requiring the method to return it?
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java
<https://reviews.apache.org/r/4790/#comment15734>
Not sure this has to be an abstract method if its purpose (as I am thinking about it -- correct me if I'm wrong) is to clear the workflow instance entry out of the repository (because in #clearAllMetadata, you are clearing the inst met). I would just make this a similarly protected method and implement it. IOW, you have a handle to the wm with wmc, so just use it to remove the inst from the repo.
- Chris
On 2012-04-22 03:39:06, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-22 03:39:06)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> This addresses bug OODT-212.
> https://issues.apache.org/jira/browse/OODT-212
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Sheryl John <sh...@gmail.com>.
> On 2012-04-22 04:01:06, Chris Mattmann wrote:
> > Looking good Sheryl. Keep trucking. I would consider putting public javadoc and all public methods (even protected ones, instructing a user how to sub-class, and what the method is going to do. It'll help reviewing the patches too).
Thanks! Will do.
- Sheryl
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7118
-----------------------------------------------------------
On 2012-04-22 03:39:06, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-22 03:39:06)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> This addresses bug OODT-212.
> https://issues.apache.org/jira/browse/OODT-212
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7118
-----------------------------------------------------------
Looking good Sheryl. Keep trucking. I would consider putting public javadoc and all public methods (even protected ones, instructing a user how to sub-class, and what the method is going to do. It'll help reviewing the patches too).
- Chris
On 2012-04-22 03:39:06, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-22 03:39:06)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> This addresses bug OODT-212.
> https://issues.apache.org/jira/browse/OODT-212
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>
Re: Review Request: Rollback capability for workflows
Posted by Sheryl John <sh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/
-----------------------------------------------------------
(Updated 2012-04-22 03:39:06.684341)
Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
Changes
-------
Updated as per Chris's comments.
Summary
-------
First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
This addresses bug OODT-212.
https://issues.apache.org/jira/browse/OODT-212
Diffs (updated)
-----
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
Diff: https://reviews.apache.org/r/4790/diff
Testing
-------
none
Thanks,
Sheryl
Re: Review Request: Rollback capability for workflows
Posted by Chris Mattmann <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4790/#review7033
-----------------------------------------------------------
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java
<https://reviews.apache.org/r/4790/#comment15621>
Yep, and next step here should be to get a handle (probably want to do this as a private class member variable) to the wmgr via XmlRpcWorkflowManagerClient, and then persist the metadata update to the instance repository, by calling wmgr.updateMetadata(metadata);
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java
<https://reviews.apache.org/r/4790/#comment15622>
I'd make this a public method.
https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java
<https://reviews.apache.org/r/4790/#comment15623>
should be public.
- Chris
On 2012-04-18 17:15:08, Sheryl John wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4790/
> -----------------------------------------------------------
>
> (Updated 2012-04-18 17:15:08)
>
>
> Review request for oodt, Chris Mattmann, brian Foster, Ricky Nguyen, Paul Ramirez, and Thomas Bennett.
>
>
> Summary
> -------
>
> First draft of the 'least dramatic' option suggested by Chris to support OODT-212 feature.
> Not sure of other expended resources that should be cleared up here and maybe there's a better way of doing this.
>
>
> Diffs
> -----
>
> https://svn.apache.org/repos/asf/oodt/trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/RollbackableWorkflowTaskInstance.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/4790/diff
>
>
> Testing
> -------
>
> none
>
>
> Thanks,
>
> Sheryl
>
>